Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wipes adapter response parameter #5134

Merged
merged 1 commit into from
Apr 17, 2020
Merged

fix wipes adapter response parameter #5134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/wipesBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ function isBidRequestValid(bid) {

function buildRequests(validBidRequests, bidderRequest) {
return validBidRequests.map(bidRequest => {
const bidId = bidRequest.bidId
const params = bidRequest.params;
const asid = params.asid;
return {
method: 'GET',
url: ENDPOINT_URL,
data: {
asid: asid,
bid_id: bidId,
}
}
});
Expand All @@ -40,7 +42,7 @@ function interpretResponse(serverResponse, bidRequest) {
if (cpm !== 0) {
const netRevenue = (response.netRevenue === undefined) ? true : response.netRevenue;
const bidResponse = {
requestId: response.uuid,
requestId: response.bid_id,
cpm: cpm,
width: response.width,
height: response.height,
Expand Down
11 changes: 6 additions & 5 deletions modules/wipesBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,11 @@ var adUnits = [
}
},
bids: [{
bidder: 'wipes',
params: {
asid: 'dWyPondh2EGB_bNlrVjzIXRZO9F0k1dpo0I8ZvQ'
}
}]
bidder: 'wipes',
params: {
asid: 'dWyPondh2EGB_bNlrVjzIXRZO9F0k1dpo0I8ZvQ'
bid_id: '51ef8751f9aead',
}
}]
}]
```
4 changes: 3 additions & 1 deletion test/spec/modules/wipesBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ describe('wipesBidAdapter', function () {
'url': ENDPOINT_URL,
'data': {
'asid': 'dWyPondh2EGB_bNlrVjzIXRZO9F0k1dpo0I8ZvQ',
'bid_id': '23beaa6af6cdde',
}
}
];
Expand All @@ -106,7 +107,8 @@ describe('wipesBidAdapter', function () {
'cpm': 850,
'status_message': '',
'currency': 'JPY',
'video_creative_id': 600004
'video_creative_id': 600004,
'bid_id': '23beaa6af6cdde'
}
};

Expand Down