-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShowHeroes adapter v2 #5085
Merged
Merged
ShowHeroes adapter v2 #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bfcdb91.
musikele
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Apr 20, 2020
* 'master' of https://github.com/prebid/Prebid.js: Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145) New LuponMedia Bid Adapter (prebid#5120) Feature/send publisher domain (prebid#5121) update test adunit params (prebid#5135) add parameter to the conversant adapter to override the url (prebid#5133) Replace call to old url module with call to utils (prebid#5136) GumGum: uses encodeURIComponent inline (prebid#5124) User ID's (liveramp, britepool) and gdpr (prebid#5114) fix wipes adapter response (prebid#5134) Submitting Tercept Analytics Adapter (prebid#5099) hotfix - undefined consent (prebid#5127) parrableIdSystem: Send current page location to back-end (prebid#5123) Increment pre version Prebid 3.16.0 Release Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039) Update appnexusBidAdapter.js (prebid#4893) Quantcast: Block bids without purpose 1 consent (prebid#5046) ShowHeroes adapter v2 (prebid#5085) Qc/qc usersyncs (prebid#4923)
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Apr 20, 2020
* master: Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145) New LuponMedia Bid Adapter (prebid#5120) Feature/send publisher domain (prebid#5121) update test adunit params (prebid#5135) add parameter to the conversant adapter to override the url (prebid#5133) Replace call to old url module with call to utils (prebid#5136) GumGum: uses encodeURIComponent inline (prebid#5124) User ID's (liveramp, britepool) and gdpr (prebid#5114) fix wipes adapter response (prebid#5134) Submitting Tercept Analytics Adapter (prebid#5099) hotfix - undefined consent (prebid#5127) parrableIdSystem: Send current page location to back-end (prebid#5123) Increment pre version Prebid 3.16.0 Release Use a deepmerge function to merge both globa level config & bidder specific config (prebid#5039) Update appnexusBidAdapter.js (prebid#4893) Quantcast: Block bids without purpose 1 consent (prebid#5046) ShowHeroes adapter v2 (prebid#5085) Qc/qc usersyncs (prebid#4923)
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* add ShowHeroes Adapter * ShowHeroes adapter - expanded outstream support * Revert "ShowHeroes adapter - expanded outstream support" This reverts commit bfcdb91. * ShowHeroes adapter - expanded outstream support * ShowHeroes adapter - fixes (prebid#4222) * ShowHeroes adapter - banner and outstream fixes (prebid#4222) * ShowHeroes adapter - description and outstream changes (prebid#4222) * ShowHeroes adapter - increase test coverage and small fix * ShowHeroes Adapter - naming convention issue * Mixed AdUnits declaration support Co-authored-by: veranevera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Refactoring and implementing the new version of the adapter