Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audigent Segmentation Real-time Data Provider #4834

Merged
merged 7 commits into from
Mar 5, 2020

Conversation

antlauzon
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This changeset adds a real time data module for retrieving Audigent user segmentation data for unified ids. Using this real time data module, rtb adapters can supply rich segmentation data at request time in order to better target audiences.

Audigent is a next-generation data management platform and a first-of-a-kind "data agency" containing some of the most exclusive content-consuming audiences across desktop, mobile and social platforms.

modules/audigentRtdProvider.js Outdated Show resolved Hide resolved
@bretg
Copy link
Collaborator

bretg commented Feb 26, 2020

@anthonylauzon - sorry, we're backed up. But just skimming this in a few seconds, I notice that you haven't provided unit tests. Please add them. We require 80% coverage.https://github.com/prebid/Prebid.js/tree/master/test/spec/modules

More importantly though, I don't understand what your module is actually doing. Note that I'm semi-technical, but don't have a lot of time to dig into this. Please explain how it's supposed to make the user segments available to bid adapters and why it needs a

.

@bretg bretg requested a review from jsnellbaker February 26, 2020 22:07
@bretg bretg assigned jsnellbaker and unassigned msm0504 Feb 26, 2020
@antlauzon
Copy link
Contributor Author

@brettg can you point me at a RTD module that has a unit test example?

This real-time data module provides first-party Audigent segments that can be attached to bid request objects destined for different SSPs in order to optimize targeting. Audigent maintains a large database of first-party Tradedesk Unified ID to third party segment mappings that can now be queried at bid-time.

@bretg
Copy link
Collaborator

bretg commented Feb 27, 2020

@bretg bretg requested review from pm-harshad-mane and removed request for msm0504 February 28, 2020 14:38
@antlauzon
Copy link
Contributor Author

Not sure why CircleCI is failing but 'gulp lint' is working on my machine

@antlauzon antlauzon requested a review from bretg February 28, 2020 23:15
@antlauzon
Copy link
Contributor Author

@bretg can you kick off another CircleCI build? I am not sure what these failures are resulting from. gulp test passes locally.

@pm-harshad-mane
Copy link
Contributor

Hello @anthonylauzon ,

I have triggered the CI job again, let's see.

@pm-harshad-mane
Copy link
Contributor

Hello @anthonylauzon
Could you please add documentation in "audigentRtdProvider.md" file about

@antlauzon
Copy link
Contributor Author

@pm-harshad-mane i've made the changes requested. it's not clear to me why CircleCI is failing. Are there non-deterministic tests in master?

@pm-harshad-mane
Copy link
Contributor

@anthonylauzon the CI job is failing due to reasons unrelated to the changes you have made, I have restarted the CI job.

@antlauzon
Copy link
Contributor Author

I think that the PR is ready for merge. Are there any other modifications you would like made?

@pm-harshad-mane
Copy link
Contributor

@anthonylauzon can you provide test credentials to try-out Audigent module?
I just wanted to see it in a working example.

@antlauzon
Copy link
Contributor Author

antlauzon commented Mar 4, 2020

@pm-harshad-mane no credentials needed. just run gulp serve --modules=userId,unifiedIdSystem,rtdModule,audigentRtdProvider,rubiconBidAdapter and look at http://localhost:9999/integrationExamples/gpt/audigentSegments_example.html

Copy link
Contributor

@pm-harshad-mane pm-harshad-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @anthonylauzon
Thank you for providing a test-page, can you please add link to the test-page in the audigentRtdProvider.md ?

@pm-harshad-mane pm-harshad-mane added needs 2nd review Core module updates require two approvals from the core team and removed needs review needs unit tests labels Mar 4, 2020
@antlauzon
Copy link
Contributor Author

Integration example added to the readme.

@jsnellbaker
Copy link
Collaborator

Hi @anthonylauzon

I tried to load the test page you mentioned above with the noted modules, but it seems like I'm hitting a CORS error against the endpoint:

Access to XMLHttpRequest at 'https://seg.ad.gt/api/v1/rtb_segments?tdid=null' from origin 'http://localhost:9999' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

I noticed the tdid was null in this case. Is there something extra I should do here?

@antlauzon
Copy link
Contributor Author

@jsnellbaker you will need to use a localhost CORS allowing extension to allow the request to load or disable CORS for localhost in the browser.

@jsnellbaker jsnellbaker merged commit b71bed1 into prebid:master Mar 5, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* audigentRtdProvider

* fix line error

* fix tests

* deep equal test fix

* conditionally set data in html5 local storage, add markdown readme

* add integration test instructions to audigent readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants