Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new bid adapter for ConnectAd #4806

Merged
merged 7 commits into from
Apr 10, 2020
Merged

Add new bid adapter for ConnectAd #4806

merged 7 commits into from
Apr 10, 2020

Conversation

rtuschkany
Copy link
Contributor

Type of change

  • New bidder adapter

Description of change

New Adapter for ConnectAd (formerly ServerBid Alias)

{
  bidder: 'connectad',
  params: {
         siteId: 123456,
         networkId: 123456
  }
}
  • contact email of the adapter’s maintainer: [email protected]
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

ConnectAd is currently a bidder-alias of the ServerBid Adapter. As the ServerBid-Adapter is not maintained anymore, please add our new ConnectAd Adapter.

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2020

This pull request introduces 1 alert when merging 1894e61 into 613b99b - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@stale

This comment has been minimized.

@stale stale bot added the stale label Feb 17, 2020
@rtuschkany

This comment has been minimized.

@stale stale bot removed the stale label Feb 17, 2020
@rtuschkany

This comment has been minimized.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all the imports to include the '.js' extension

test/spec/modules/connectadBidAdapter_spec.js Show resolved Hide resolved
@idettman idettman added the docs label Mar 6, 2020
@rtuschkany
Copy link
Contributor Author

@idettman @mike-chowla thanks for reviewing! I've fixed all imports.

@rtuschkany rtuschkany requested a review from idettman March 13, 2020 14:15
@stale
Copy link

stale bot commented Mar 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 27, 2020
@rtuschkany
Copy link
Contributor Author

@mike-chowla hi mike! just a quick reminder as I've received a stale message. Thx!

@stale stale bot removed the stale label Mar 30, 2020
@rtuschkany
Copy link
Contributor Author

@mike-chowla @idettman hey guys! Any update on this? We are already waiting for two months to get this approved. Thx!

@idettman idettman removed the docs label Apr 10, 2020
@idettman idettman merged commit 67a1cb1 into prebid:master Apr 10, 2020
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Apr 16, 2020
* 'master' of https://github.com/prebid/Prebid.js: (102 commits)
  Marsmedia - Add vastXml and fix id response (prebid#5067)
  PubMatic adapter to support image sync (prebid#5104)
  minor consentManagement fix (prebid#5050)
  fix circle ci failing tests (prebid#5113)
  Add Relaido Adapter (prebid#5101)
  Add new bid adapter for ConnectAd (prebid#4806)
  change payload (prebid#5105)
  Utils updates (prebid#5092)
  Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086)
  Criteo : added first party data mapping to bidder request (prebid#4954)
  updateAdGenerationManual (prebid#5032)
  New bid adapter: Wipes (prebid#5051)
  Prebid manager analytics utm tags (prebid#4998)
  CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075)
  isSafariBrowser update  (prebid#5077)
  Support min &max duration for onevideo (prebid#5079)
  increment pre version
  Prebid 3.15.0 release
  prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064)
  Prebid adapter for windtalker (prebid#5040)
  ...
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* Add new bid adapter for ConnectAd

* Add new bid adapter for ConnectAd

* Conditional fix

* js.fix

* js-fix

* EOF-fix

* EOF-Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants