Fix for early auction close with video + done cb cleanup #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Sep 4, 2018
src/auction.js
Outdated
| let doneCalled = 0; | ||
| return function() { | ||
| doneCalled++; | ||
| if (doneCalled === bidderCount) { |
There was a problem hiding this comment.
are we concerned that some bidders will call multiple done callbacks causing the auction to close early?
| } | ||
| } | ||
|
|
||
| function adapterDone() { |
There was a problem hiding this comment.
what do we need adapterDone for?
|
Honestly was pretty confused reading the code. Let's walk through this a bit. |
mkendall07
requested changes
Sep 6, 2018
mkendall07
changed the title
jsnellbaker
requested changes
Sep 11, 2018
There was a problem hiding this comment.
Hi @jaiminpanchal27 I did some testing with multiple video ad units and mix of instream/outstream and it seems like the auction is completing successfully after the bids were cached.
See some additional points to consider below.
src/auction.js
Outdated
| } | ||
|
|
||
| function adapterDone() { | ||
| // events.emit(CONSTANTS.EVENTS.BIDDER_DONE, bidderRequest); |
There was a problem hiding this comment.
Can remove commented code (if we truly do not need to emit this event here).
| let bidRequest = getBidderRequest(bidRequests, bid.bidderCode, adUnitCode); | ||
| let bidResponse = getPreparedBidForAuction({adUnitCode, bid, bidRequest, auctionId}); | ||
|
|
||
| if (bidResponse.mediaType === 'video') { |
There was a problem hiding this comment.
Should add logic (here?) to clarify only for instream video adUnits, since outstream video adUnits shouldn't need to be cached.
src/auction.js
Outdated
| @@ -316,7 +356,7 @@ function addBidToAuction(auctionInstance, bidResponse) { | |||
| } | |||
|
|
|||
| // Video bids may fail if the cache is down, or there's trouble on the network. | |||
| function tryAddVideoBid(auctionInstance, bidResponse, bidRequest) { | |||
| function tryAddVideoBid(auctionInstance, bidResponse, bidRequest, afterBidAdded) { | |||
There was a problem hiding this comment.
Could remove bidRequest from arguments here since it doesn't appear to be used now with these new changes.
# Conflicts: # test/spec/auctionmanager_spec.js
ptomasroos
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Sep 25, 2018
* done cb cleanup * rename some vars * added unit tests, updates after changes requested * add deprecated notice to function
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* done cb cleanup * rename some vars * added unit tests, updates after changes requested * add deprecated notice to function
SublimeJeremy
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Oct 1, 2018
* done cb cleanup * rename some vars * added unit tests, updates after changes requested * add deprecated notice to function
2 tasks
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* done cb cleanup * rename some vars * added unit tests, updates after changes requested * add deprecated notice to function
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* done cb cleanup * rename some vars * added unit tests, updates after changes requested * add deprecated notice to function
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* done cb cleanup * rename some vars * added unit tests, updates after changes requested * add deprecated notice to function
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* done cb cleanup * rename some vars * added unit tests, updates after changes requested * add deprecated notice to function
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Cleaning up done callback which closes the auction. Simplifying the design.