Rubicon Bid Adapter: expand fastlane EID protocol and pass p_site.mobile; Support device.ip and device.ipv6. #12471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h source, retain ppuid logic; Add ip and ipv6 from device in bidRequest
robertrmartinez
requested changes
Nov 19, 2024
| @@ -3,7 +3,6 @@ import { pbsExtensions } from '../libraries/pbsExtensions/pbsExtensions.js'; | |||
| import { registerBidder } from '../src/adapters/bidderFactory.js'; | |||
| import { config } from '../src/config.js'; | |||
| import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js'; | |||
| import { find } from '../src/polyfill.js'; | |||
There was a problem hiding this comment.
This is not used anywhere? It def should not be!
modules/rubiconBidAdapter.js
Outdated
| @@ -542,42 +543,47 @@ export const spec = { | |||
| if (bidRequest?.ortb2Imp?.ext?.ae) { | |||
| data['o_ae'] = 1; | |||
| } | |||
| // If the bid request contains a 'mobile' property under 'ortb2.site', add it to 'data' as 'p_site.mobile'. | |||
| if (bidRequest?.ortb2?.site?.mobile) { | |||
There was a problem hiding this comment.
If defined mobile is either 0 or 1
So, with this current code it would only pass it if it was 1 since 0 is falsy.
So lets add typeof here and pass along.
if (typeof bidRequest?.ortb2?.site?.mobile === 'number') {Also add a test to confirm p_site.mobile
patmmccann
approved these changes
Nov 19, 2024
robertrmartinez
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update Rubicon PBJS adapter to pass enhanced EID data, site.mobile, and IP information