Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aniview: Removed setting the AV_WIDTH/AV_HEIGHT, bidWidth/bidHeight to imp.ext for video. #12418

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Aniview: Removed setting the AV_WIDTH/AV_HEIGHT, bidWidth/bidHeight to imp.ext for video. #12418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions modules/aniviewBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ const converter = ortbConverter({
imp(buildImp, bidRequest, context) {
const { mediaType } = context;
const imp = buildImp(bidRequest, context);
const isVideo = mediaType === VIDEO;
const isBanner = mediaType === BANNER;
const { width, height } = getSize(context, bidRequest);
const floor = getFloor(bidRequest, { width, height }, mediaType);
Expand All @@ -43,14 +42,7 @@ const converter = ortbConverter({
imp.bidfloorcur = DEFAULT_CURRENCY;
}

if (isVideo) {
deepSetValue(imp, `ext.${BIDDER_CODE}`, {
AV_WIDTH: width,
AV_HEIGHT: height,
bidWidth: width,
bidHeight: height,
});
} else if (isBanner) {
if (isBanner) {
// TODO: remove once serving will be fixed
deepSetValue(imp, 'banner', { w: width, h: height });
}
Expand Down
1 change: 0 additions & 1 deletion test/spec/modules/aniviewBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ describe('Aniview Bid Adapter', function () {
expect(url).equal('https://rtb.aniview.com/sspRTB2');
expect(method).equal('POST');
expect(imp[0].tagid).equal(CHANNEL_ID_1);
expect(imp[0].ext.aniview.AV_HEIGHT).equal(VIDEO_SIZE.height);
expect(imp[0].id).equal(videoBidRequest.bids[0].bidId);
expect(ext.aniview.pbjs).equal(1);
});
Expand Down