Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bid Adapters pulling tmax from config instead of bidderRequest object #9705

Closed
35 tasks
Justin-Quinn51 opened this issue Mar 23, 2023 · 2 comments · Fixed by #9770
Closed
35 tasks

Bid Adapters pulling tmax from config instead of bidderRequest object #9705

Justin-Quinn51 opened this issue Mar 23, 2023 · 2 comments · Fixed by #9770
Assignees
@ChrisHuie

Comments

@Justin-Quinn51
Copy link
Contributor

Type of issue

Enforcement

Description

The following bid adapters are pulling tmax from config.getConfig('bidderTimeout'):

  • acuityAds
  • amx
  • appush
  • beyondMedia
  • brave
  • brightcom
  • brightcomSSP
  • coinzilla
  • compass
  • contextexchange
  • glimpse
  • globalsun
  • grid
  • gridNM
  • gumgum
  • iqzone
  • kobler
  • kueez
  • luponmedia
  • mathildeads
  • medianet
  • minutemedia
  • nexx360
  • onomagic
  • operaads
  • pubmatic
  • rise
  • sharethrough
  • shinez
  • smarthub
  • synacormedia
  • truereach
  • videoheroes
  • visiblemeasures
  • vrtcal

Other information

References #9287
@patmmccann patmmccann mentioned this issue Mar 24, 2023
Closed
@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Mar 27, 2023
@Justin-Quinn51 Justin-Quinn51 mentioned this issue Apr 5, 2023
Merged
@patmmccann patmmccann linked a pull request Apr 6, 2023 that will close this issue
Various Bid Adapters: point tmax at request object #9770
Merged
@Justin-Quinn51 Justin-Quinn51 mentioned this issue Apr 10, 2023
Closed
25 tasks
@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table Apr 11, 2023
@patmmccann patmmccann reopened this Oct 30, 2023
@patmmccann
Copy link
Collaborator

patmmccann commented Oct 30, 2023 •
edited
Loading

A bunch of these remain eg

Prebid.js/modules/visxBidAdapter.js

Line 115 in 56292c4

const bidderTimeout = Number(config.getConfig('bidderTimeout')) || timeout;

Prebid.js/modules/emtvBidAdapter.js

Line 157 in 56292c4

tmax: config.getConfig('bidderTimeout')

@patmmccann patmmccann moved this from Open to Ready for Dev in Prebid.js Tactical Issues table Oct 30, 2023
@patmmccann
Copy link
Collaborator

https://github.com/search?q=repo%3Aprebid%2FPrebid.js+getconfig+biddertimeout+path%3A%2F%5Emodules%5C%2F%2F&type=code

@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisHuie ChrisHuie

Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various Bid Adapters: point tmax at request object Justin-Quinn51/Prebid.js
3 participants
@patmmccann @ChrisHuie @Justin-Quinn51