Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 8 - Consolidate size mapping logic #9597

Closed
ChrisHuie opened this issue Feb 27, 2023 · 3 comments · Fixed by #9893
Closed

Prebid 8 - Consolidate size mapping logic #9597

ChrisHuie opened this issue Feb 27, 2023 · 3 comments · Fixed by #9893

Comments

@ChrisHuie
Copy link
Collaborator

This issue is to propose and track the consolidation the logic around size mapping for individual bidders

@dgirardi
Copy link
Collaborator

Tentative proposal:

  • move the v1 logic into a module (the same sizeMappingV2 module)? and expand it to work on video/native as well
  • from prebid 8, people interested in mediaQuery mapping and labels should include the module.

@dgirardi
Copy link
Collaborator

Related: #4135 (sizeMapping V1 does not work for video/native). This is an opportunity to consolidate v1 and v2.

@patmmccann
Copy link
Collaborator

Inclusion dependent on minimal configuration impact to publishers using existing module(s)

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Apr 24, 2023
@dgirardi dgirardi moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table May 3, 2023
@patmmccann patmmccann linked a pull request May 25, 2023 that will close this issue
1 task
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants