Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native targeting keys are not set for bids that use ORTB native responses #9246

Closed
JulieLorin opened this issue Nov 15, 2022 · 6 comments · Fixed by #9252
Closed

Native targeting keys are not set for bids that use ORTB native responses #9246

JulieLorin opened this issue Nov 15, 2022 · 6 comments · Fixed by #9252
Assignees

Comments

@JulieLorin
Copy link
Collaborator

Type of issue

I think this is a bug (but I may have missed something on native changes on Prebid)

Description

We tried to implement IX on native, but it seems that since #8853, Index Exchange adapter returns a naive bid response with openrtb format instead of Prebid native.

Actual results

Index exchange native bid response :
image

Expected results

Regular native bid response :
image

Is this an issue with IX bid adapter or should we adapt to handle this kind of native response ?

@dgirardi
Copy link
Collaborator

ORTB and the Prebid-proprietary formats should be interchangeable, but it's of course possible that something was overlooked. Could you expand on what you mean by "adapt"?

@JulieLorin
Copy link
Collaborator Author

ORTB and the Prebid-proprietary formats should be interchangeable, but it's of course possible that something was overlooked. Could you expand on what you mean by "adapt"?

I am not sure how they should be interchangeable (sorry I am not aware of all the context).

On our side, we are working directly with the native object from the bid response to render the ad on the page. So having an object with properties like body, icon, title, etc... is not interchangeable with having an "ortb" object with assets and ids.

In this case, the native targetings are not available to the adserver (we are NOT using sendTargetingKeys: false in the adunit)
With an object like that, there are no native targetings :
image
For another "regular" native bid response, I have native targetings :
image
This seems like an inconsistent behavior but maybe native targetings are only there for legacy ?

We are not using prebid universal creative for rendering native and this is the first time I encounter a prebid native bidder responding with this kind of bid response, which is not handled on our side. I tried to check changelogs about a change of native bid response format/spec and could not find anything.
If this is the correct behavior, we will adapt, but is there any spec as to what to expect as a native bid response ?

Thanks

@dgirardi
Copy link
Collaborator

@JulieLorin - the difference in targeting is indeed a bug. It does not sound like that's the only thing you are missing though; are you working the bid response object directly for rendering (from bidsBackHandler?)

The change in format comes from #8086. Part of the strategy is to translate ORTB native responses to the Prebid format so that it would maintain compatibility with existing creatives, but we were assuming that those would be interfacing through the same postMessage protocol that PUC uses. So the translation is not available to you if you're dealing with bid responses directly - which is something we can fix.

However, the long term plan is to allow ORTB in the adunit definition itself, and at that point it won't necessarily be true that a given native response can always be translated into the prebid native format. This may or may not matter in your case (if you control the adunit definitions you can choose to keep them in the prebid format and continue to get prebid responses back).

@dgirardi dgirardi self-assigned this Nov 15, 2022
@dgirardi dgirardi changed the title Index Exchange bid adapter returns wrong native format Native targeting keys are not set for bids that use ORTB native responses Nov 15, 2022
@JulieLorin
Copy link
Collaborator Author

JulieLorin commented Nov 16, 2022

@JulieLorin - the difference in targeting is indeed a bug. It does not sound like that's the only thing you are missing though; are you working the bid response object directly for rendering (from bidsBackHandler?)

Yes exactly, we are directly using the bid object from bidsBackHandler (and more precisely the native property for native rendering)

The change in format comes from #8086. Part of the strategy is to translate ORTB native responses to the Prebid format so that it would maintain compatibility with existing creatives, but we were assuming that those would be interfacing through the same postMessage protocol that PUC uses. So the translation is not available to you if you're dealing with bid responses directly - which is something we can fix.

Thanks for the link to the PR, I was not aware of this transition, and we are indeed not using the same protocol as PUC uses.
I think it's always nice to have backward compatibility for this of course, especially as it seems all the conversion work has been done, but instead of being added on the bid response native property, it is added only at the time of the postMessage response to retrieve all assets (I think that was the point of https://github.com/prebid/Prebid.js/pull/8086/files#r920200871 but the choice was to not modify the initial native response)

I can try to create a pull request that adds the parameters at bid response level instead of at the time of the post message if that seems OK

@patmmccann
Copy link
Collaborator

patmmccann commented Nov 21, 2022

@ix-prebid-development

@patmmccann
Copy link
Collaborator

@ix-prebid-support

@dgirardi dgirardi moved this from Triage to PR submitted in Prebid.js Tactical Issues table Nov 21, 2022
Repository owner moved this from PR submitted to Done in Prebid.js Tactical Issues table Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants