Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error assigning bid key-values since 7.20.0 #9245

Closed
reelcitizen opened this issue Nov 15, 2022 · 10 comments
Closed

Error assigning bid key-values since 7.20.0 #9245

reelcitizen opened this issue Nov 15, 2022 · 10 comments
Assignees

Comments

@reelcitizen
Copy link

Type of issue

Bug

Description

Since version 7.20.0 I get the below error when Prebid tries to assign bid key-values to ad units...

Exception in queued GPT command TypeError: e.getStatusCode is not a function

Steps to reproduce

In my script I'm using Prebid like this so it works in parallel with other header bidders... the prebid_units are defined by their DOM element ID and not their GAM ad unit ID.

pbjs.requestBids({
      adUnits: prebid_units,
      bidsBackHandler: () => {
        googletag.cmd.push(() => {
          pbjs.setTargetingForGPTAsync();
          requestManager.prebid = true;
          biddersBack();
        });
      },
      timeout: this.biddingTimeout,
});

With running Prebid 7.20.0 or higher I then get the following in the PBJS debug console...

Exception in queued GPT command TypeError: e.getStatusCode is not a function

This means the bidder key-values are not assigned to each GAM ad unit.

I assume it's related to this change: #9013

Expected results

Key-values are added to each ad unit on the page/

Actual results

Screenshot 2022-11-15 at 14 35 23

Platform details

Prebid 7.20.0, client-side.

Other information

Problem since #9013

@dgirardi dgirardi self-assigned this Nov 15, 2022
@dgirardi
Copy link
Collaborator

@reelcitizen, would you be able to provide a test page, or more of your pbjs setup (adunits and setConfig)? I am not able to reproduce and I suspect the issue is caused by some module interaction that I'm not currently able to find.

@dgirardi
Copy link
Collaborator

To clarify, what that stack trace tells me is that some of the bids that you're left with at the end of the auction are not "proper" bids - they don't have the properties a Prebid bid is supposed to have. We could change it so that the error goes away but you'd still be left with bids that are coming from somewhere unexpected.

@reelcitizen
Copy link
Author

Hi, thanks for taking a look. I've stripped out everything from the Prebid config and still get the error. I then tried adding/removing bidders but it didn't seem to be just one causing the problem. It seemed more about the number of bidders I was using.

With 8 bidders it seemed to work, more than that I started getting problems?

The ad config looks like this:

{
            code: "/43340684/RPS_STICKY_LB",
            mediaTypes: { banner: { sizes: [[320, 50]] } },
            bids: [
                { bidder: "rubicon", params: { accountId: "16622", siteId: "326086", zoneId: "1695086", sizes: [43] } },
                { bidder: "pubmatic", params: { publisherId: "159481", adSlot: "2969788" } },
                { bidder: "ix", params: { siteId: "545961", size: [320, 50] } },
                { bidder: "teads", params: { pageId: 127011, placementId: 138666 } },
                { bidder: "medianet", params: { cid: "8CUSVGW2K", crid: "131851077" } },
                { bidder: "sharethrough", params: { pkey: "4gSvFjPk3URipXomD5Y7r14X" } },
                { bidder: "amx", params: { tagId: "Z2FtZXItbmV0d29yay5uZXQ" } },
                { bidder: "onetag", params: { pubId: "75847b43ef0b8c2" } },
                { bidder: "criteo", params: { networkId: 11384 } },
                { bidder: 'yieldmo', params: { placementId: '3053840090234036317' } },
            ],
        }

@dgirardi
Copy link
Collaborator

@reelcitizen, do you have a live page with that config, even if it's running an earlier version of Prebid? I can try to redirect it to 7.20 on my end. Unfortunately I am still not able to reproduce.

@reelcitizen
Copy link
Author

It would be on a site like https://www.rockpapershotgun.com

@dgirardi
Copy link
Collaborator

Still unable to reproduce :(

Here are some console dumps from my attempts... I am redirecting static/src/vendor/prebid/prebid7.7.0.js to a local version of Prebid that is built with

Everything seems to work as intended; there are new "bid rejected" warnings coming from #9013:
image

But no issues when setting targeting:

image

At this point I'm afraid I need you to set up a complete page that can reproduce the issue. Sorry!

@reelcitizen
Copy link
Author

Hi, can you see if you get the error on this page please?
https://www.dicebreaker.com/games/magic-the-gathering-game/feature/magic-the-gathering-the-brothers-war-impressions

It seems to be about the number of bidders, if I take some away I can clear the error.

@reelcitizen
Copy link
Author

This is also my Prebid modules...

[
  "openxBidAdapter",
  "rubiconBidAdapter",
  "sovrnBidAdapter",
  "appnexusBidAdapter",
  "tripleliftBidAdapter",
  "pubmaticBidAdapter",
  "ixBidAdapter",
  "teadsBidAdapter",
  "medianetBidAdapter",
  "sharethroughBidAdapter",
  "amxBidAdapter",
  "onetagBidAdapter",
  "yahoosspBidAdapter",
  "criteoBidAdapter",
  "consentManagement",
  "currency",
  "enrichmentFpdModule",
  "priceFloors",
  "sharedIdSystem",
  "id5IdSystem",
  "userId",
  "rtdModule",
  "permutiveRtdProvider",
  "yieldmoBidAdapter"
]

@reelcitizen
Copy link
Author

I think I tracked this down to an extension called AdWizard which monitors ad requests on the page... weird it was causing GPT errors though, it must not recognise the new bid values.

I appreciate the help here, closing the issue.

@dgirardi
Copy link
Collaborator

@reelcitizen, be aware that 7.20 has this issue - which was rejecting some bids in my log dumps above. You may want to skip to 7.22 to pull in the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants