-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application/json connection concerns #8500
Comments
It appears https://stackoverflow.com/questions/56812188/how-to-specify-application-json-content-type-without-invoking-chromes-cors-pr suggests 'text/plain' |
Prebid.js/modules/yahoosspBidAdapter.js Line 544 in 62da3ac
|
I prefer MDN as a resource to understand when CORS preflights are not triggered: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests In general I don't think Prebid itself can act on this besides maybe issuing a recommendation to the adapters, because their backend may need work to accept "simple" requests. For example, if I am reading that spec right, any adapter that uses |
@ChrisHuie could you add a pr to the bidder page to https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests to raise awareness? |
@dgirardi by way of example, this fastlane request contained no preflight while these yahoo ones do |
@patmmccann, you are right, I was mistaken about I'm still of the opinion that this cannot/should not be reduced to the content-type (some adapters rely on custom headers for example). Each SSP should decide to make "simple" requests a goal and perform their own testing. |
@ChrisHuie any update? would love to close this out |
I will get this in this week |
closing this - tracked now by the docs PR |
#8498 indicates ajax type application/json causes performance issues. A quick search indicates it is used widely in the project. Should this be remedied?
The text was updated successfully, but these errors were encountered: