Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media.net RTD module: unstable test #8460

Closed
patmmccann opened this issue May 24, 2022 · 1 comment · Fixed by #8485
Closed

Media.net RTD module: unstable test #8460

patmmccann opened this issue May 24, 2022 · 1 comment · Fixed by #8485
Labels
bug

Comments

@patmmccann
Copy link
Collaborator

Type of issue

Please see https://app.circleci.com/pipelines/github/prebid/Prebid.js/11443/workflows/e0845e9e-b598-4d09-bb24-ba6b22ca632a/jobs/22197

Your tests shouldn't actually call and execute your js.
@patmmccann patmmccann added the bug label May 24, 2022
@patmmccann
Copy link
Collaborator Author

patmmccann commented May 24, 2022 •
edited
Loading

Your js doesnt work so we deleted all your tests in #8463 . Please fix all three issues, that your tests call your js, and that your js doesnt work, and that you don't use the loadexternalscript method. or we'll be forced to remove the module from the project in prebid 7 coming out next month.

@patmmccann patmmccann moved this from Triage to Tracking in Prebid.js Tactical Issues table May 25, 2022
@patmmccann patmmccann linked a pull request May 27, 2022 that will close this issue
Medianet Rtd Provider: restore unit test file with script stub #8485
Merged
3 tasks
Repository owner moved this from Tracking to Done in Prebid.js Tactical Issues table May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Medianet Rtd Provider: restore unit test file with script stub media-net/Prebid.js
1 participant
@patmmccann