Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong auctionDelay behavior in realTimeData module #8139

Closed
hierro1981 opened this issue Mar 3, 2022 · 3 comments · Fixed by #8214
Closed

Wrong auctionDelay behavior in realTimeData module #8139

hierro1981 opened this issue Mar 3, 2022 · 3 comments · Fixed by #8214
Assignees
Labels

Comments

@hierro1981
Copy link

Type of issue

auctionDelay in realTimeData behaviour isn't correct

Description

As per doc, auctionDelay should be an upper limit that RTD will wait for module with waitForIt at true for a response, but this is not the case.
Its managed as a fixed time the RTD will wait, also if the modules get the response before.

Steps to reproduce

set the following config for RTD:
realTimeData = { auctionDelay: 50000, dataProviders: [ { name: "ias", waitForIt: true, params: { pubId: "929966" } } ] }

set bidders timeout to 10000 and make a call.
Prebid will make IAS RTD module call, IAS give response after around 150ms, RTD module will wait for 50 seconds, after 10 seconds prebid will trigger timeout.

Expected results

RTD IAS module will make call, after having the response bidders start make request without waiting the 50sec auctionDelay.

Actual results

Platform details

Tested with Prebid v5.20.2 and v6.13.0

@dgirardi dgirardi self-assigned this Mar 3, 2022
@dgirardi
Copy link
Collaborator

dgirardi commented Mar 3, 2022

I believe this is a problem with the IAS rtd module, introduced in #7431 (@raguilar-ias can you verify?). callback is never called, so Prebid times out:

function getBidRequestData(reqBidsConfigObj, callback, config, userConsent) {
const adUnits = reqBidsConfigObj.adUnits || getGlobal().adUnits;
const { pubId } = config.params;
const queryString = constructQueryString(pubId, adUnits);
ajax(
`${IAS_HOST}?${queryString}`,
getApiCallback(),
undefined,
{ method: 'GET' }
);
}

@dgirardi dgirardi removed their assignment Mar 3, 2022
@dgirardi dgirardi added the bug label Mar 3, 2022
@rbarbini-ias
Copy link
Contributor

I can confirm that we're looking into it on the IAS side.

@patmmccann
Copy link
Collaborator

@rbarbini-ias ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants