ShareThrough bid adapter returns HTTP 204.

[dbirkbeck]

Type of issue

Bug

Description

Starting in Prebid 5.13, the ShareThrough bid adapter returns an HTTP 400 code with no bid responses. In recent builds it now returns an HTTP 204 with no bid responses.

Steps to reproduce

Using chrome developer tools, inspect the bid request/response for the ShareThrough bid.

Test page

Expected results

The bid response should return valid bids with a HTTP 200 code.

Actual results

The bid response returns no bids with either an HTTP 400 or an HTTP 204 code.

Platform details

Prebid 5.12 works as expected. Prebid 5.13 exhibits the behaviour above.

Other information

[patmmccann]

Likely a result of #7290

Shall we revert @epechuzal ?

[patmmccann]

@muuki88 the 204 on a bid response suffers from the same issue you identified on a sync, right, and the auction would not end until timeout? #6354 (comment)

[muuki88]

Really? I have to look into the implementation, but IIRC prebid has its own XMLHttpRequest implementation, which shouldn't suffer from the iframe load event issue.

however if this is the case, then we have a huge performance improvement ahead.

[patmmccann]

okay i think it must not be the case, my mistake

[dbirkbeck]

@patmmccann,@epechuzal
It appears as though an HTTP 204 response is considered normal for the Sharethrough adapter. While, the original HTTP 400 response code seems to be fixed, versions of Prebid > 5.12.0 are very broken, monetization wise, and Sharethrough doesn't seem to care. Since nothing is likely to be done, there is no point in keeping this issue open. It is surprising to me that clearly untested/unready code can make it into what is supposed to be a "stable" branch.