Criteo adapter crashes on video bidRequest if skip is 0

[muuki88]

Type of issue

Bug

Description

When the skip property is set to 0 and params.video is undefined then the Criteo adapter crashes.

Prebid.js/modules/criteoBidAdapter.js

Line 324 in 6aa63d6

skip: bidRequest.mediaTypes.video.skip || bidRequest.params.video.skip,

is responsible for this as 0 is falsy, thus triggering the second statement, which doesn't guard against undefined params.

Same goes for startdelay

Prebid.js/modules/criteoBidAdapter.js

Line 328 in 6aa63d6

startdelay: bidRequest.mediaTypes.video.startdelay || bidRequest.params.video.startdelay

Steps to reproduce

{
  adUnit: {
    mediaTypes: {
      video: {
        context: 'outstream',
        playerSize: [ [300, 250]  ],
        mimes: ['video/mp4', 'video/MPV', 'video/H264', 'video/webm', 'video/ogg'],
        minduration: 1,
        maxduration: 30,
        playbackmethod: [2, 3, 4, 5, 6],
        placement:
        api: [1, 2, 3, 4, 5, 6],
        protocols: [1, 2, 3, 4, 5, 6, 7, 8],
        skip: 0
      }
    }
  }
}

Expected results

Criteo adapter doesn't crash if one bid is misconfigured.
Also 0 is a valid configuration option.

Actual results

💥 🎆 💥

Platform details

• prebid 5.9.0

[leonardlabat]

Hello @muuki88

Thanks for filling the issue, we'll prepare a fix very soon.

[dzhang-criteo]

Hello @muuki88 ,

It should now be fixed so maybe we could close this issue?

[muuki88]

Thanks for the quick bug fix 😘