Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbjs_debug and Prebid Server #5986

Closed
bretg opened this issue Nov 16, 2020 · 5 comments
Closed

pbjs_debug and Prebid Server #5986

bretg opened this issue Nov 16, 2020 · 5 comments
Labels

Comments

@bretg
Copy link
Collaborator

bretg commented Nov 16, 2020

Type of issue

Change

Description

Right now adding pbjs_debug=true to the query string will cause the pbsBidAdapter to add test:1 to the OpenRTB.

The OpenRTB test parameter can cause different behavior in bidders. So it may be reasonable to change this behavior to add ext.prebid.debug:1 instead.

If we do decide to change:

  • should it be 5.0? Is this a "breaking change"? Kind of -- it's a different behavior in a debug scenario.
  • should we also add a pbjs_test=true query string?

Reference

prebid/prebid-server#1562

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@patmmccann
Copy link
Collaborator

The second question is still open

@patmmccann
Copy link
Collaborator

@bretg could this be solved with doc now? Could a publisher do a setConfig call on the ortb2 object to set test=1?

@bretg
Copy link
Collaborator Author

bretg commented Nov 4, 2021

Could a publisher do a setConfig call on the ortb2 object to set test=1?

Definitely.

Given that no one's asked for pbjs_test=true, this seems like a good way to close out the issue.

@bretg
Copy link
Collaborator Author

bretg commented Nov 4, 2021

Done. A request for pbjs_test query string flag should come in as a new issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants