Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON import warning in webpack 5 #5909

Closed
gpoitch opened this issue Oct 29, 2020 · 0 comments · Fixed by #5933
Closed

JSON import warning in webpack 5 #5909

gpoitch opened this issue Oct 29, 2020 · 0 comments · Fixed by #5933
Assignees
@GLStephen

Comments

@gpoitch
Copy link
Contributor

gpoitch commented Oct 29, 2020

Type of issue

bug

Description

Webpack 5 emits a warning when importing named exports from json files:

"WARNING in ../../node_modules/prebid.js/src/secureCreatives.js 15:16-30
Should not import the named export 'EVENTS'.'BID_WON' (imported as 'EVENTS') from default-exporting module (only default export is available soon)"

Expected results

No warnings

Actual results

A warning coming from src/secureCreatives.js

Platform details

Prebid 4.13.0, macOS, node 14, webpack 5

Other information

This is the fix/PR: https://github.com/gpoitch/Prebid.js/pull/1/files
Having some odd trouble with trying to view/PR anything in this repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GLStephen GLStephen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix import warning for webpack 5
2 participants
@GLStephen @gpoitch