Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example pages are failing gdpr checks because they are using TCF v1 #5718

Closed
smenzer opened this issue Sep 9, 2020 · 6 comments
Closed

example pages are failing gdpr checks because they are using TCF v1 #5718

smenzer opened this issue Sep 9, 2020 · 6 comments
Assignees
Labels
in progress pinned won't be closed by stalebot

Comments

@smenzer
Copy link
Collaborator

smenzer commented Sep 9, 2020

Type of issue

bug

Description

The example pages that use a CMP are relying on TCF v1 and the original vendor list file originally located here: https://vendorlist.consensu.org/vendorlist.json (which is now a dead link). The TCF v2 vendorlist is https://vendorlist.consensu.org/v2/vendor-list.json and the CMP in the tests need to be updated to support it.

Steps to reproduce

  • gulp serve
  • open http://localhost:9999/integrationExamples/gpt/userId_example.html?pbjs_debug=true and look at the console or network tab to see errors

Related to

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 4, 2020
@smenzer
Copy link
Collaborator Author

smenzer commented Oct 6, 2020

still an issue

@stale stale bot removed the stale label Oct 6, 2020
@smenzer smenzer added the pinned won't be closed by stalebot label Oct 6, 2020
@iamnewton
Copy link
Contributor

Hey @smenzer, I'm new to the project and going to work on this issue but I was wondering a few things and hoping you could clarify for me.

  1. Is this still an issue? From my testing, all of the references to that URL have been commented out
  2. When I uncomment and fix the URL as suggested, I'm getting errors on that URL, but not a 404 as I would expect based on your comment, but more a CORS issue. Is that what you're seeing as well?

@gglas
Copy link

gglas commented Mar 8, 2021

We're going to split this up -

  1. We're going to clean up website + github examples and delete any that contain references to a CMP (we currently think there are two). @ChrisHuie

  2. @giniyat202 @ian-lr would you mind helping us update the CMP examples to include up-to-date information? Seems like it connects to Proposal to use CMP in e2e tests #6377

  3. We'll start up a larger "example refresh project" in a separate issue and do a double hceck to make sure all examples (both on github and on the website) are up to date. @ChrisHuie to connect with @patmmccann on other outstanding updates that we need.

@gglas
Copy link

gglas commented May 10, 2021

@ChrisHuie to double check on 1 -- we expect that this is complete.

@giniyat202 and @ian-lr -- we'll be closing this issue, if you wouldn't mind providing CMP examples for your solutions we'd be happy to add further example pages.

@gglas
Copy link

gglas commented Aug 2, 2021

@ChrisHuie confirming that prebid examples are complete, @giniyat202 and @ian-lr please feel free to open new issues to enhance the documentation if needed.

@gglas gglas closed this as completed Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress pinned won't be closed by stalebot
Projects
None yet
Development

No branches or pull requests

4 participants