You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Earlier, log messages in sizeMappingV2 assumed ad unit code to be a unique identifier. But, after introduction of 'identical' ad unit pattern, that's no longer the case. This leads to some degree of ambiguity in log messages. For example, for the above ad unit, and screen size, 1000px, the second ad unit should be disabled.
Here's the generated log messages:
Reading it, it's impossible to figure out which ad unit got disabled, the first one or the second one.
Potential Solution
Add identifier in paranthesis which would be unique. For example, for the above ad units, the first ad unit will read ad-code-1 (1) and second ad unit will read ad-code-1 (2)
If anyone has any better idea, please do share with me.
The text was updated successfully, but these errors were encountered:
Type of issue
With the merge of this PR, #5062, sizeMappingV2 supports ad unit declarations with the same code. Here's an example of ad unit with same code:
Find more details about this pattern here: #5044, #3226 (comment)
Earlier, log messages in sizeMappingV2 assumed ad unit code to be a unique identifier. But, after introduction of 'identical' ad unit pattern, that's no longer the case. This leads to some degree of ambiguity in log messages. For example, for the above ad unit, and screen size, 1000px, the second ad unit should be disabled.
Here's the generated log messages:
Reading it, it's impossible to figure out which ad unit got disabled, the first one or the second one.
Potential Solution
Add identifier in paranthesis which would be unique. For example, for the above ad units, the first ad unit will read
ad-code-1 (1)
and second ad unit will readad-code-1 (2)
If anyone has any better idea, please do share with me.
The text was updated successfully, but these errors were encountered: