Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safeframe resize fix doe not select correct element #4418

Closed
vkimcm opened this issue Nov 4, 2019 · 2 comments
Closed

Safeframe resize fix doe not select correct element #4418

vkimcm opened this issue Nov 4, 2019 · 2 comments
Labels

Comments

@vkimcm
Copy link
Collaborator

vkimcm commented Nov 4, 2019

Type of issue

bug

Description

#3988

There were still issues with above fix, our footer was not getting resized because footer div was not the last element of the parent, rather close button element is. We need different solution that does not use last-child css.

@vkimcm vkimcm changed the title Safeframe resize fix doe not select last child Safeframe resize fix doe not select correct element Nov 4, 2019
@andyblackwell
Copy link
Contributor

In case you happen to use a custom build and also use GAM like us, we changed the selectors to this, which works better for us:
['div[id^="google_ads_iframe"]', 'iframe[id^="google_ads_iframe"]']

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 20, 2019
@stale stale bot closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants