ShowHeroes doesn't supply its own renderer for outstream

[muuki88]

Undocumented behaviour

Description

The showheroes adapter introduced in #3733 doesn't support oustream, but doesn't state this in the documentation nor does it valdidate the mediaTypes.video.context

Steps to reproduce

Configure a showheroers bid

{
  code: 'adslot-1,
  mediaTypes: {
    video: {
      context: 'outstream',
      playerSize: [ [ 605, 340 ] ]
    }
  },
  bids: [
    {
      bidder: 'showheroes-bs',
      params: {
        playerId: 'xxxxxx-xxxxxx-xxxxx-xxxxx'
      }
    }
  ]
}

Expected results

1. The adapter documentation states that only outstream is supported
2. The adapter ignores mediaType.video if the context is oustream

Actual results

The prebid function isValidVideoBid logs an error.

ERROR: Invalid bid from showheroes-bs.
 Ignoring bid: Video bid does not have required vastUrl or renderer property

Platform details

prebid 2.30.0.

Other information

• ShowHeroes Adapter #3733
• ShowHeroes Adapter Dev @vadim-mazzherin

[patrickjae]

Hi!
Thanks for bringing this up. Could you please confirm the reported behavior when changing the parameter value of mediaTypes.video.playerSize to a simple list as documente here.
I.e. does the configuration

{
  code: 'adslot-1,
  mediaTypes: {
    video: {
      context: 'outstream',
      playerSize: [ 605, 340 ]
    }
  },
  bids: [
    {
      bidder: 'showheroes-bs',
      params: {
        playerId: 'xxxxxx-xxxxxx-xxxxx-xxxxx'
      }
    }
  ]
}

also not work?
Thanks,
Patrick

[muuki88]

Hi @patrickjae 😃

Sorry for the late reply.

Changing the playerSize setting doesn't change anything. I updated the initial report with the log message.

ERROR: Invalid bid from showheroes-bs. Ignoring bid: Video bid does not have required vastUrl or renderer property

The request is sent and a response comes back, but it's not what prebid expects. I must have overlooked this line here, which indicates that outstream is supported. However I don't see any renderer specified. Doesn't showhero provide it's own renderer (video player)?

cheers,
Muki

[muuki88]

As an example on how to define a renderer

• AppNexus Adpater newRenderer and AppNexus Adapter oustreamRenderer
• SpotX Adapter and SpotX Adapter createOutstreamScript & outstreamRenderer
• Unruly Adapter

[patrickjae]

Thanks for the pointers, I have passed this on to our developers, they will take over from here as soon as possible.
Best,
Patrick

[vadim-mazzherin]

Thanks for the pointers, I'm working on this issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[muuki88]

dear stale bot. This issue is not stale. A pull request is being reviewed 😝

[muuki88]

Thanks 😚

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[muuki88]

we'll close this ticket once the PR is merged

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mgntrn]

Did anyone manage to get ShowHeroes working with Prebid outstream? We're receiving bids but even though ShowHeroes is the highest bidder another bidder wins the auction. There are no console errors.