Teads: Adapter doesn't respect media types - sizes don't work

[muuki88]

Type of issue

bug

Description

The Teads Adapter, still uses the deprecated bid.sizes property and doesn't differentiate between banner and video media types.

This

cc: @valsouche

Steps to reproduce

Use a video only ad unit. See #3222

Expected results

Teads should use the mediaTypes sizes for video and/or banner instead of the deprecated sizes property.

Platform details

• prebid version 1.35.0

Other information

• MediaTypes are not respected by multiple bidders #3222 - this issue already mentioned the problem, but didn't get fixed
• only set mediaTypes.banner.sizes from sizes if mediaTypes doesn't exist. #3274 - IMHO due to this, teads somehow worked before 1.33.0

[muuki88]

This is especially weird as the bid.sizes property should include the videos sizes. At least if I read this code in der adapterManager.js correctly.

It almost looks as if the video player sizes override the banner.

The OpenX adapter handles the video playerSize explicitly.

[muuki88]

The reasons for this behavior is buried in the getBids function, which simply used the mediaTypes.banner.sizes and discards everything that has been done before.

[valsouche]

In this pull request (#3377), @bretg says that playerSize is an optional field. But like @muuki88 said, for some reason, if from a video adunit mediatypes there is no playerSize, bid sizes equals[], even if there is a sizes property on the adUnit.

It looks like only banner sizes are copy in adUnit.sizes.

When mediaTypes.video there is only a check on playerSize (in adapterManager.js) and no on mediaTypes.video.sizes, why ? And why bid sizes property could contains only banner or [] here: https://github.com/prebid/Prebid.js/blob/master/src/adaptermanager.js#L97 ? It means bid.sizes is only available for banner.

Is it something expected ? Should we explicitly check each sizes possibility from adapter ?

Thanks in advance,
Val.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[muuki88]

Before this ticket is getting stale.

@valsouche are opening a PR to fix this?

[muuki88]

Should be fixed in the next release.