-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Native] Slot targeting not sent to DFP with nativ position and banner position #2902
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@haroldpussat
|
Thanks for the feedback, I was OOO and I'm back now. As mentionnent by Christian from Appnexus, maybe there is a limit reached with DFP (8192 characters per request on asynchronous render) : https://support.google.com/admanager/answer/1628457?hl=en I'll let you know when it's done. |
On this enableSendAllBid->false, I can see ad (not all ad I want as I didn't create several lineItem ready for SendAllBid -> false). The requested URL to DFP has a length of 6603 characters |
@haroldpussat |
Just a quick update here. I was able to confirm that DFP will silently drop keywords when it hits the max URL length defined. Because max URL length for DFP is influenced by a number of factors (number of adUnits, Sizes etc) I cannot give an absolute max for keywords but in my test with a single adUnit it started to be a problem when my total character count (Key + value) was over 6,325. Unfortunately we most likely cannot figure out at run time the max to use, so Prebid.js will have to figure out some sensible rules here to prevent this from happening. |
We faced exactly same problem. Not like other bids, native bid has too many data to pass, based on my test, when there are more than 3 native bids returns inside one call, then the problem happens. Workaround we use to mitigate the issue:
and call this function right before With this change, it reduces size of dfp request with native bid about 40%, and I notice one ad call now can support up to about 5 native bids. I think it works for most scenarios, at least it covers most of scenarios for us. |
If I'm not mistaken the solution provided with removeUnnecessaryNativeKeys is nearly like SendAllBids : false ? With SendAllBids : false, only winning bid will be sent to DFP, even if you have more than one native actor, there is only on native key / value sent to DFP. |
Not 100% understand the issue you refer to. Inside http://www.precom-multimedia.com/interne/hpu/test_nativ5/index_notallsendbids.html?dfptest=40&pbjs_debug=true, |
currently working on a solution to this issue by not sending the click_url data to DFP. More soon. |
@naoto0822 For your reference |
@robertrmartinez Thx! |
@mkendall07 @robertrmartinez |
yes #3573 solved this. |
Type of issue
question
Description
Still testing native implementation, I'm facing an unsolved issue with combination of native position and legacy banner position on a same page. What I can see in a case I mix nativ position and legacy banner position is that slot targeting to DFP is not sent to DFP and in that case, there is no ad served to the page.
On my test page, I have several position
All positions are running fine with Prebid.
Case 1 : One position setup with prebid : pub_banniere_medium is declared as native with mediaType and a size of [1,1] --> Results : Ok, targeting is done correctly and ad is delivered
Case 2 : 2 positions setup with prebid : pub_banniere_medium is declared as native with mediaType and a size of [1,1], pub_pave1 is declared as banner with mediaType and also size
--> Results : OK, targeting is done correctly and ads are delivered
Case 3 (PROD target): 6 positions setup with Prebid : pub_banniere_medium is declared as native with mediaType and a size of [1,1], all other positions are declared as banner with mediaType and also size
--> Results : KO Often, there is no ad delivered at all, even if prebid answered with valid bids.
When I received bid for native, it seems some of them are running fine and some other are not running correctly
For example : If I go on https://www.ouestfrance-auto.com/ and pick up a random car to get retargeted. I often get a bid from OuestFrance auto and the issue is raised
For example : If I go on https://www.homly-you.com/ to get retargeted, I often get a bid from Homly You and the native ad is diplayed correctly)
I have some clue about the behaviour, from my understanding the slot targeting is sent to DFP via params "prev_scp". For case 1 and case 2, this params seems correct :
For case 3, this params is not visible :
Even if I received prebid bid
Even if the googletag.slot seems to have a correct targeting. This is an output of the object slot for pub_banniere_medium (the native), after the pbjs.setTargetingForGPTAsync and before the googletag.refresh
I'm not able to get the rootcause of this issue (no error from DFP, or DFP console, or browser console), and this is blocking for us to go live. I don't know if it's an issue from Prebid or DFP or from my setup
I did test with several prebid version
1.16
1.18-pre
1.18-pre custom (with encodeURIComponent for native key-value only, to fix #2854 issue
Steps to reproduce
Prebid version 1.*
Chrome / Firefox / Opera : last version
Declared an ad position with mediaType : native : {} and a size of [1,1]
EnableSendAllBids : true
I also try to play with SuppressEmptyKeys (true | none)
Have a simple native mediaType for at least one position and other positions are legacy banner
The issue is raised more often with https://www.ouestfrance-auto.com/ native ad (I can see with them if needed, how they did setup their native ad)
Test page
All test pages are with Prebid 1.18-pre custom (including a encodeURIComponent for native value)
Case 1 (only native) :
http://www.precom-multimedia.com/interne/hpu/test_nativ5/index_only_native.html?dfptest=40&pbjs_debug=true
Case 2 (one native + 1 legacy banner) :
http://www.precom-multimedia.com/interne/hpu/test_nativ5/index_only_native_2_positions.html?dfptest=40&pbjs_debug=true
Case 3 (one native + 5 legacy banner) :
http://www.precom-multimedia.com/interne/hpu/test_nativ5/index_custom.html?dfptest=40&pbjs_debug=true
Expected results
Case 1 : adex ad for other positions. Native prebid ad for pub_banniere_medium
Case 2 : adex ad for other positions. Legacy banner prebid / adex ad for pub_pave1, Native prebid ad for pub_banniere_medium
Case 3 : adex ad for other positions. Legacy banner prebid / adex ad for pub_pave1, Native prebid ad for pub_banniere_medium
Actual results
Case 3 : After being retargeted, No ad delivered at all and slot targeting to DFP seems not sent (via prev_scp)
Platform details
Prebid 1.*
Other information
The text was updated successfully, but these errors were encountered: