Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2sTesting module unit test fails in Prebid 1.0 #1723

Closed
jaiminpanchal27 opened this issue Oct 18, 2017 · 2 comments
Closed

s2sTesting module unit test fails in Prebid 1.0 #1723

jaiminpanchal27 opened this issue Oct 18, 2017 · 2 comments
Assignees
@snapwich @harpere @jaiminpanchal27
Labels
needs review Prebid 1.0

Comments

@jaiminpanchal27
Copy link
Collaborator

Type of issue

Bug/Refactor

Description

s2sTesting module unit test needs to be fixed for 1.0 due to changes in adaptermanager and config modules.

Steps to reproduce

Add tests to prebid-1.0 branch and run tests

Other information

@harpere #1678
@ndhimehta ndhimehta added the ready label Nov 6, 2017
@harpere
Copy link
Collaborator

harpere commented Nov 14, 2017

unit tests and adaptermanager problems fixed in #1829, though waiting for the prebidServerAdapter to be finished to run end-to-end tests.

@snapwich
Copy link
Collaborator

New updates in #1846

@bretg bretg closed this as completed Nov 29, 2017
@ghost ghost removed the in progress label Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snapwich snapwich

@harpere harpere

@jaiminpanchal27 jaiminpanchal27

Labels
needs review Prebid 1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@snapwich @bretg @harpere @jaiminpanchal27 @ndhimehta