You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
getBidderRequestsCounter cannot find the "requestsCounter" when the adunit code contains too many "." (dots). Google Ad Manager GPT allows ad unit codes with more than one dot in the ad unit code.
Go to console & filter for "INFO: Bids Requested for Auction with id"
Notice, the bidderRequestsCount for Rubicon is 1, but Rise is 0.
-- Rubicon ad unit code is "test-slot"
-- Rise ad unit code is "gpt-ad-mayoclinic.org-top.bidders.rise"
Notice, in the network tab there are two bid requests for Rubicon and Rise. Filter for /fastlane|yellowblue/
BUG
getBidderRequestsCounter cannot find the "requestsCounter" when the adunit code contains too many "." (dots). Google Ad Manager GPT allows ad unit codes with more than one dot in the ad unit code.
Description
Prebid.js/src/adUnits.js
Line 66 in 360c3ea
When it reached
getBidderRquestsCounter()
, the adunit is being parsed by ".".So the ad unit
gpt-ad-mayoclinic.org-top
is broken down asinstead of
Steps to reproduce
-- Rubicon ad unit code is "test-slot"
-- Rise ad unit code is "gpt-ad-mayoclinic.org-top.bidders.rise"
Test page
https://hyunjoo-test-environment.s3.amazonaws.com/public/github/getBidderRequestsCount/testpage.html?pbjs_debug=true
Expected results
I expected to see bidderRequestsCount to be equivalent to the number of requests in the network tab.
Actual results
I see uneven bidderRequestsCount against the number of requests I see under the network tab.
Platform details
I can see this issue from v8.48.0.
Other information
This is affecting Bidder Rise because Rise is using bids.bidderRequestCount in their bid request payload, here:
Prebid.js/libraries/riseUtils/index.js
Line 126 in ac5cc64
This is also affecting other bidders count.
The text was updated successfully, but these errors were encountered: