Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media.net Analytics and Bid Adapter: import common functions #11936

Open
patmmccann opened this issue Jul 5, 2024 · 1 comment
Open

Media.net Analytics and Bid Adapter: import common functions #11936

patmmccann opened this issue Jul 5, 2024 · 1 comment

Comments

@patmmccann
Copy link
Collaborator

  _getAttributeFromSelector and other adjacent functions should be imported by both adapters. 

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀

Originally posted by @github-actions[bot] in #11924 (comment)

@patmmccann
Copy link
Collaborator Author

cc @adish1997 @adish-r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tracking
Development

No branches or pull requests

1 participant