fledgeForGPT module may assume Prebid adunit.code matches GPT slot

[bretg]

Type of issue

Potential bug

Description

In today's Tools meeting, @florianerl reported a potential issue with the fledgeForGPT module - that it's not working when the Prebid Adunit.code doesn't match a GPT slot. It's valid for Prebid adunit.codes to be divId other even a customSlotMatching function value.

Perhaps this line of code is near the source of the potential issue -- could this be generalized to first check if adunit.code is a GPT slot, and if not, check for div or customSlotMatching?

Prebid.js/modules/fledgeForGpt.js

Line 37 in f6040c4

const gptSlot = getGptSlotForAdUnitCode(adUnitCode);

Unfortunately I don't have first hand data or a test page, but we've had issues before along these lines, so it seems plausible. So the first step would be to see if we have test cases that cover the divid and customSlotMatching scenarios.

[dgirardi]

the current logic expects the ad unit code to be either a GAM ad unit path or the div ID:

Prebid.js/src/utils.js

Line 798 in 78f93cd

export const compareCodeAndSlot = (slot, adUnitCode) => slot.getAdUnitPath() === adUnitCode || slot.getSlotElementId() === adUnitCode;

customSlotMatching is a parameter to setTargetingForGptAsync. We can replicate it for setPAAPIConfigForGPT - or we could extract it into a configuration parameter.

[ptomasroos]

Just bumped into this when I was about to enable fledge on my ad slots which purely uses customSlotMatching.
I would say, adding customSlotMatching into the setPAAPIConfigForGPT function would be right way to approach this, having the same flexibility to filter gpt slots

Prebid.js/src/targeting.js

Line 424 in 0f91aff

Object.keys(targetingConfig).filter(customSlotMatching ? customSlotMatching(slot) : isAdUnitCodeMatchingSlot(slot))

[adtechnology]

When will this be fixed?

[patmmccann]

fixed in #11714