Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent User ID Module: Eliminating live-connect NPM Dependency. #11541

Closed
3link opened this issue May 22, 2024 · 3 comments · Fixed by #12167
Closed

LiveIntent User ID Module: Eliminating live-connect NPM Dependency. #11541

3link opened this issue May 22, 2024 · 3 comments · Fixed by #12167

Comments

@3link
Copy link
Contributor

3link commented May 22, 2024

Type of issue

Eliminating live-connect NPM dependency.

Description

The goal of this issue is to get rid of the LiveConnect NPM module dependency.

Instead, the following approach should be implemented: The LiveIntent user ID module will rely on the LiveConnect script being present on the page. This LiveConnect script will accept commands and execute them according to the configuration passed along with them (e.g. what to resolve, privacy settings, callbacks, etc.).

The user ID module implementation will look like in the snippet below:

window.liQHub = window.liQHub || [];

decode(value, config) {
  const sync = {
	  config: config,
	  commands: [{
		command: "sync"
	  }]
  }
  window.liQHub.push(sync)
  // decode the value
}

getId(config) {
  const result = function(callback) {
  	const syncAndResolve = {
  		config: config,
  		commands: [
  			{
				command: "sync"
  			},
	  		{
	  			command: 'resolve',
	      		onSuccess: response => {callback(response)},
	      		onError: error => {callback()}
	  		}
  		]
  	}
     window.liQHub.push(syncAndResolve)
  }
  return {callback: result}
}
@3link
Copy link
Contributor Author

3link commented May 22, 2024

Hi @SKOCHERI @patmmccann @jdwieland8282. The proposal is as communicated in Slack. We started working on it this week. There is no PR in Prebid yet as we have to rewrite LiveConnect from scretch first.

@patmmccann patmmccann moved this from Triage to Tracking in Prebid.js Tactical Issues table Jun 3, 2024
@patmmccann
Copy link
Collaborator

@3link excluding the import in geographies you don't function had a rather noticeable performance improvement; this speaks to the potential opportunity in the geographies where you do from the disentangling

@3link
Copy link
Contributor Author

3link commented Jul 9, 2024

@patmmccann Do you mean bidding performance or technical (time to load the script, time to bid etc.)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants