Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33across id module: does not work in Europe; still sends network request #10495

Closed
patmmccann opened this issue Sep 15, 2023 · 12 comments · Fixed by #10714
Closed

33across id module: does not work in Europe; still sends network request #10495

patmmccann opened this issue Sep 15, 2023 · 12 comments · Fixed by #10714
Labels

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 15, 2023

Type of issue

bug

Description

33across id module has a gvlid and the module passes gdpr consent strings

Should we just delete the gvlid from the module?

Expected results

gdpr enforcement suppresses 33across, or the module suppresses the endpoint call when gdpr applies

Actual results

33across responds with a we do not support this country error

image

@patmmccann
Copy link
Collaborator Author

related prebid/prebid.github.io#4866

@patmmccann
Copy link
Collaborator Author

patmmccann commented Jan 30, 2024

33 across drops all requests with usnat strings now
image

We'd look to see both of these issues rectified before Prebid 9 or risk some sort of enforcement by Prebid js team. Your module should prevent network traffic in unsupported regimes.

@patmmccann patmmccann changed the title 33across id module: has gvlid but not gdpr support? 33across id module: does not work in USA or Europe Jan 30, 2024
@curlyblueeagle
Copy link
Contributor

curlyblueeagle commented Jan 31, 2024

@patmmccann Developer from 33Across here. We are looking into the issue regarding US Nat and are working on a fix.

@curlyblueeagle
Copy link
Contributor

@patmmccann we released a fix yesterday to our servers and seen a big reduction in the number of US Nat requests dropped. Can you please try again? Also do you mind sharing the details of you tests that resulted in requests being dropped? So we can try them at our end too and make sure we haven't missed anything? Thanks.

@patmmccann
Copy link
Collaborator Author

patmmccann commented Feb 1, 2024

Awesome! We'll send you a test page shortly

@patmmccann patmmccann changed the title 33across id module: does not work in USA or Europe 33across id module: does not work in Europe; still sends network request Feb 1, 2024
@patmmccann
Copy link
Collaborator Author

cafedelites.com/?commit=e949a58

@curlyblueeagle
Copy link
Contributor

Thanks! The test page now appears to be making calls and getting proper responses from our endpoint. So I am assuming US Nat is no longer an issue.

With respect to GPDR we plan to implement your suggestion #10714 (comment) in that same PR. Our developer working on it will get back to you over there.

@patmmccann
Copy link
Collaborator Author

@curlyblueeagle tyvm! I will mark that pr as closes this issue. Thanks for the engagement!

@patmmccann patmmccann linked a pull request Feb 2, 2024 that will close this issue
9 tasks
@curlyblueeagle
Copy link
Contributor

No problem, thanks for bringing this to our attention.

@carlosfelix
Copy link
Contributor

@patmmccann We have made the GDPR changes based on what was suggested.

Changes have been incorporated to PR 10714

@carlosfelix
Copy link
Contributor

Just a reminder that changes are part of PR 10714, please take a look when you have a chance.

@patmmccann
Copy link
Collaborator Author

Excellent thanks for your attention on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants