Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify that gDSFP is not called if neither props nor state have changed #1123

Merged
merged 1 commit into from
May 27, 2018
Merged

Specify that gDSFP is not called if neither props nor state have changed #1123

merged 1 commit into from
May 27, 2018

Conversation

andrewiggins
Copy link
Member

Adds an additional unit test for getDerivedStateFromProps that mirrors a unit test that React added recently

@andrewiggins andrewiggins changed the title Spec gDSFP is not called if neither props nor state have changed Specify that gDSFP is not called if neither props nor state have changed May 27, 2018
marvinhagemeister
marvinhagemeister approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! More tests are always welcome 👍 👍

@marvinhagemeister marvinhagemeister merged commit fd62f6a into preactjs:master May 27, 2018
@andrewiggins andrewiggins deleted the add-gDSFP-test branch May 27, 2018 07:48
@andrewiggins
Copy link
Member Author

Cool! If I come across more behaviors that would be useful to specify in tests, I'll open PRs for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewiggins @marvinhagemeister