Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on render loop detection #4381

Closed
1 task
alexander-entin opened this issue May 11, 2024 · 1 comment · Fixed by #4382
Closed
1 task

False positive on render loop detection #4381

alexander-entin opened this issue May 11, 2024 · 1 comment · Fixed by #4382

Comments

@alexander-entin
Copy link

  • Check if updating to the latest Preact version resolves the issue

Describe the bug
"Too many re-renders" error shows and the app stops when there is no real issue.

To Reproduce
https://stackblitz.com/edit/vitejs-vite-kuwua3?file=src%2Fmain.tsx

Steps to reproduce the behavior:

  1. Click the button 25 times
  2. See error

Expected behavior
No error, counter == 25

@howlowck
Copy link

RL example of hitting this issue (more common than hitting the same button 25 times) is when there is any controlled text input. After typing 25 characters in the input box, boom error, and the input becomes uncontrolled. Please push a new patch version with #4382 fix. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants