Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Event normalization is missing for onChangeCapture #388

Open
i-like-robots opened this issue May 25, 2017 · 1 comment
Open

Event normalization is missing for onChangeCapture #388

i-like-robots opened this issue May 25, 2017 · 1 comment

Comments

@i-like-robots
Copy link

i-like-robots commented May 25, 2017

React automatically sets capturing to true for the change event but since preactjs/preact@727f036#diff-4935bb00e75b7854383877cbfd9d770f Preact favours explicitly appending Capture to event attributes.

However this change has not yet been reflected in react-compat, specifically for the onInput/onChange normalization (CC i-like-robots/react-tags#75).

I've setup some demos here comparing the behaviour of React vs Preact with this module.

React with onChange: https://codepen.io/anon/pen/ZKPrRr
React with onChangeCapture: https://codepen.io/anon/pen/WjmMKp
Preact with onChange: https://codepen.io/anon/pen/OmqQoN
Preact with onChangeCapture: https://codepen.io/anon/pen/KmEoKQ

If I get some time I'm happy to help with this =]

@developit
Copy link
Member

Help would be lovely for this - I was thinking of pinging you when I made that change in Preact 8 (knew it would have an effect on *Capture).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants