You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(Describe the feature, bug, question, proposal that you are requesting)
We found that the configurations for the readinessProbe and livenessProbe are only set with default value when the entire probe configuration is nil.
When we do not specify any probe configuration, all the configs, e.g. initialDelaySeconds, timeout_seconds are set with default values, such as 10 seconds.
Then when we deploy the zookeeper cluster with spec.probes.livenessProbe.initialDelaySeconds as 5 seonds, all other fields are set with 1 seconds now.
But if we first have a deployed zookeeper cluster, and then change spec.probes.livenessProbe.initialDelaySeconds to 5 seconds, all other fields would have the correct default value.
Importance
(Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have))
Importance: should-have
Location
(Where is the piece of code, package, or document affected by this issue?)
The default is set here:
Description
(Describe the feature, bug, question, proposal that you are requesting)
We found that the configurations for the readinessProbe and livenessProbe are only set with default value when the entire probe configuration is nil.
When we do not specify any probe configuration, all the configs, e.g.
initialDelaySeconds
,timeout_seconds
are set with default values, such as 10 seconds.Then when we deploy the zookeeper cluster with
spec.probes.livenessProbe.initialDelaySeconds
as5
seonds, all other fields are set with 1 seconds now.But if we first have a deployed zookeeper cluster, and then change
spec.probes.livenessProbe.initialDelaySeconds
to5
seconds, all other fields would have the correct default value.Importance
(Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have))
Importance: should-have
Location
(Where is the piece of code, package, or document affected by this issue?)
The default is set here:
zookeeper-operator/api/v1beta1/zookeepercluster_types.go
Line 565 in 28d1f69
Suggestions for an improvement
The default values should be set on per field basis, rather than only when the entire struct is nil, to avoid the inconsistency
(How do you suggest to fix or proceed with this issue?)
The text was updated successfully, but these errors were encountered: