Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm config spec cannot be set because the some paths are incorrect #299

Closed
kentakozuka opened this issue Jan 27, 2021 · 1 comment · Fixed by #305
Closed

Helm config spec cannot be set because the some paths are incorrect #299

kentakozuka opened this issue Jan 27, 2021 · 1 comment · Fixed by #305

Comments

@kentakozuka
Copy link
Contributor

kentakozuka commented Jan 27, 2021

Description

In the zookeeper helm chart, some config specs cannot be set because the paths are incorrect.
They should be;

    {{- if .Values.config.xxxx}}
    xxxx: {{ .Values.config.xxxx }}
    {{- end }}

But in some lines, they are;

    {{- if .Values.config.xxxx}}
    xxxx: {{ .Values.xxxx }}
    {{- end }}

Location

config:
{{- if .Values.config.initLimit }}
initLimit: {{ .Values.config.initLimit }}
{{- end }}
{{- if .Values.config.tickTime }}
tickTime: {{ .Values.config.tickTime }}
{{- end }}
{{- if .Values.config.syncLimit }}
syncLimit: {{ .Values.config.syncLimit }}
{{- end }}
{{- if .Values.config.globalOutstandingLimit }}
globalOutstandingLimit: {{ .Values.config.globalOutstandingLimit }}
{{- end }}
{{- if .Values.config.preAllocSize }}
preAllocSize: {{ .Values.config.preAllocSize }}
{{- end }}
{{- if .Values.config.snapCount }}
snapCount: {{ .Values.config.snapCount }}
{{- end }}
{{- if .Values.config.commitLogCount }}
commitLogCount: {{ .Values.config.commitLogCount }}
{{- end }}
{{- if .Values.config.snapSizeLimitInKb }}
snapSizeLimitInKb: {{ .Values.snapSizeLimitInKb }}
{{- end }}
{{- if .Values.config.maxCnxns }}
maxCnxns: {{ .Values.maxCnxns }}
{{- end }}
{{- if .Values.config.maxClientCnxns }}
maxClientCnxns: {{ .Values.maxClientCnxns }}
{{- end }}
{{- if .Values.config.minSessionTimeout }}
minSessionTimeout: {{ .Values.minSessionTimeout }}
{{- end }}
{{- if .Values.config.maxSessionTimeout }}
maxSessionTimeout: {{ .Values.maxSessionTimeout }}
{{- end }}
{{- if .Values.config.autoPurgeSnapRetainCount }}
autoPurgeSnapRetainCount: {{ .Values.autoPurgeSnapRetainCount }}
{{- end }}
{{- if .Values.config.autoPurgePurgeInterval }}
autoPurgePurgeInterval: {{ .Values.config.autoPurgePurgeInterval }}
{{- end }}
{{- if .Values.config.quorumListenOnAllIPs }}
quorumListenOnAllIPs: {{ .Values.config.quorumListenOnAllIPs }}
{{- end }}
{{- end }}

Suggestions for an improvement

It is necessary to set correct paths.

@SrishT
Copy link
Contributor

SrishT commented Feb 24, 2021

@kentakozuka this would require a minor fix. Would u like to send out a PR in order to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants