Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PR validation tasks in GithubActions #148

Closed
4 tasks done
spiegela opened this issue Mar 24, 2020 · 3 comments · Fixed by #377
Closed
4 tasks done

Create PR validation tasks in GithubActions #148

spiegela opened this issue Mar 24, 2020 · 3 comments · Fixed by #377
Assignees
@derekm @anishakj
Milestone
Release 0.2.13

Comments

@spiegela
Copy link
Contributor

spiegela commented Mar 24, 2020 •
edited by derekm
Loading

PR validation tasks required:

  • unit tests passed
  • Go lint checking via golangci-lint
  • Code quality and coverage should have positive change

Perhaps e2e tests should not be included in PR validation, and instead within release validation, but I'm open to discussion on this topic. I'm also flexible on what code quality and coverage reporting we'd like to use, but I'm a fan of both Codacy and Code Climate.

TODO

  • Add DCO check
  • Add Codecov checks
  • Make DCO, build, and Codecov checks required
  • Configure Codecov
@pbelgundi
Copy link
Contributor

@spiegela What does the scope of this issue cover other than E2E tests?

@pbelgundi pbelgundi added status/question Further information is requested duplicate This issue or pull request already exists labels Mar 26, 2020
@derekm derekm self-assigned this Jul 28, 2021
@derekm
Copy link
Contributor

derekm commented Jul 28, 2021

Added DCO check, and made DCO & build checks required.

@anishakj anishakj removed duplicate This issue or pull request already exists status/question Further information is requested labels Jul 29, 2021
@anishakj anishakj changed the title Create PR validation tasks in Travis-CI Create PR validation tasks in GithubActions Jul 29, 2021
@derekm
Copy link
Contributor

derekm commented Jul 29, 2021 •
edited
Loading

Added Codecov checks and made them required.

Default Codecov thresholds can be changed by committing a .codecov.yml config file to the root of this repo. Cf., https://github.com/pravega/pravega/blob/master/.codecov.yml

@anishakj anishakj mentioned this issue Aug 2, 2021
Merged
@anishakj anishakj added this to the Release 0.2.13 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekm derekm

@anishakj anishakj

Labels
None yet
Projects
None yet
Milestone
Release 0.2.13
Development

Successfully merging a pull request may close this issue.

Issue 148: Configuring codecov for PR validation tasks pravega/zookeeper-operator
4 participants
@spiegela @derekm @anishakj @pbelgundi