diff --git a/charts/zookeeper-operator/values.yaml b/charts/zookeeper-operator/values.yaml index 909e53626..e29ffb4ce 100644 --- a/charts/zookeeper-operator/values.yaml +++ b/charts/zookeeper-operator/values.yaml @@ -20,6 +20,7 @@ serviceAccount: crd: create: true -## Specifies which namespace the Operator should watch over. -## An empty string means all namespaces. +## Specifies which namespace(s) the Operator should watch over. +## Default: An empty string means all namespaces. +## Multiple namespaces can be configured using a comma separated list of namespaces watchNamespace: "" diff --git a/cmd/manager/main.go b/cmd/manager/main.go index 6a0d390d2..8aa70def5 100644 --- a/cmd/manager/main.go +++ b/cmd/manager/main.go @@ -16,6 +16,7 @@ import ( "fmt" "os" "runtime" + "strings" "github.com/operator-framework/operator-sdk/pkg/k8sutil" "github.com/operator-framework/operator-sdk/pkg/leader" @@ -25,6 +26,7 @@ import ( "github.com/pravega/zookeeper-operator/pkg/version" _ "k8s.io/client-go/plugin/pkg/client/auth/gcp" _ "k8s.io/client-go/plugin/pkg/client/auth/oidc" + "sigs.k8s.io/controller-runtime/pkg/cache" "sigs.k8s.io/controller-runtime/pkg/client/config" "sigs.k8s.io/controller-runtime/pkg/manager" logf "sigs.k8s.io/controller-runtime/pkg/runtime/log" @@ -63,11 +65,24 @@ func main() { os.Exit(0) } - namespace, err := k8sutil.GetWatchNamespace() + namespaces, err := k8sutil.GetWatchNamespace() if err != nil { log.Error(err, "failed to get watch namespace") os.Exit(1) } + //When operator is started to watch resources in a specific set of namespaces, we use the MultiNamespacedCacheBuilder cache. + //In this scenario, it is also suggested to restrict the provided authorization to this namespace by replacing the default + //ClusterRole and ClusterRoleBinding to Role and RoleBinding respectively + //For further information see the kubernetes documentation about + //Using [RBAC Authorization](https://kubernetes.io/docs/reference/access-authn-authz/rbac/). + managerWatchCache := (cache.NewCacheFunc)(nil) + if namespaces != "" { + ns := strings.Split(namespaces, ",") + for i := range ns { + ns[i] = strings.TrimSpace(ns[i]) + } + managerWatchCache = cache.MultiNamespacedCacheBuilder(ns) + } // Get a config to talk to the apiserver cfg, err := config.GetConfig() @@ -80,7 +95,7 @@ func main() { leader.Become(context.TODO(), "zookeeper-operator-lock") // Create a new Cmd to provide shared dependencies and start components - mgr, err := manager.New(cfg, manager.Options{Namespace: namespace}) + mgr, err := manager.New(cfg, manager.Options{NewCache: managerWatchCache}) if err != nil { log.Error(err, "") os.Exit(1)