Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admission Controller for PravegaCluster resource #7

Closed
maddisondavid opened this issue Jul 12, 2018 · 3 comments · Fixed by #159
Closed

Admission Controller for PravegaCluster resource #7

maddisondavid opened this issue Jul 12, 2018 · 3 comments · Fixed by #159
Labels
kind/enhancement Enhancement of an existing feature priority/P2 Slight inconvenience or annoyance to applications, system continues to function

Comments

@maddisondavid
Copy link
Contributor

Currently the resource contains the Bookkeeper and Pravega image definitions. The operator should have sensible defaults set in its configuration and apply these to the resource via a mutating Admission Controller.
@maddisondavid maddisondavid added the kind/enhancement Enhancement of an existing feature label Jul 16, 2018
@maddisondavid maddisondavid self-assigned this Jul 17, 2018
@adrianmo adrianmo added status/blocked Issue or PR is blocked on another item; add reference in a comment priority/P2 Slight inconvenience or annoyance to applications, system continues to function labels Nov 21, 2018
@adrianmo adrianmo changed the title Set default Image in Pravega Operator configuration Set default values in Pravega Operator configuration Nov 21, 2018
@adrianmo
Copy link
Contributor

Blocked by: operator-framework/operator-sdk#269

@adrianmo
Copy link
Contributor

Related to #88

@adrianmo adrianmo changed the title Set default values in Pravega Operator configuration Admission Controller for PravegaCluster resource Nov 21, 2018
@adrianmo adrianmo mentioned this issue Dec 18, 2018
Merged
@adrianmo adrianmo mentioned this issue Jan 30, 2019
Merged
@adrianmo
Copy link
Contributor

adrianmo commented Apr 2, 2019 •
edited
Loading

The admission controller should also attempt to mutate the values in the options block.

pravega-operator/pkg/apis/pravega/v1alpha1/pravega.go

Line 95 in 78d9944

Options map[string]string `json:"options"`

Option values are expected to be strings, surrounded by double quotes, otherwise the operator framework will fail to parse it and reject the CR. It'd be interesting if the admission controller could transform to strings any values passed as options.

P.S.: The same applies to BookKeeper options:

pravega-operator/pkg/apis/pravega/v1alpha1/bookkeeper.go

Line 90 in 78d9944

Options map[string]string `json:"options"`

@adrianmo adrianmo mentioned this issue Apr 3, 2019
Closed
@Tristan1900 Tristan1900 mentioned this issue Apr 5, 2019
Merged
@adrianmo adrianmo removed the status/blocked Issue or PR is blocked on another item; add reference in a comment label Apr 5, 2019
@Tristan1900 Tristan1900 mentioned this issue May 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhancement of an existing feature priority/P2 Slight inconvenience or annoyance to applications, system continues to function
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 7, 156: Admission webhook pravega/pravega-operator
2 participants
@maddisondavid @adrianmo