Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build process #4

Closed
ZachJW34 opened this issue Apr 9, 2020 · 3 comments
Closed

Improve build process #4

ZachJW34 opened this issue Apr 9, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ZachJW34
Copy link
Contributor

ZachJW34 commented Apr 9, 2020

I am integrating local search into my companies DocusaurusV2 website and it seems that the more popular plugins for local search are yours and cmfcmf's. I love the default styling that Aglolia and your package provides, but the build process that cmfcmf implements is cleaner (using the docusaurus postBuild lifecycle to generate the search metadata). Have you considered implementing a similar build process vs the build-search-data.js node script?
I'd be willing to contribute if you're interested!
@lelouch77
Copy link
Collaborator

That's a great idea @ZachJW34, definitely I will work on it ... And yes I would love to have your contribution.

Thanks.

@lelouch77 lelouch77 added the enhancement New feature or request label Apr 9, 2020
@ZachJW34
Copy link
Contributor Author

ZachJW34 commented Apr 9, 2020

I'll submit a PR for this then!

@ZachJW34 ZachJW34 mentioned this issue Apr 10, 2020
Merged
@lelouch77
Copy link
Collaborator

lelouch77 commented Apr 10, 2020 •
edited
Loading

Hey, thanks for the PR, for now, I merged it and published a mew version 1.0.0

Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lelouch77 @ZachJW34