Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pokemon-colorscripts with pokeget #1894

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rishav12s
Copy link
Contributor

Pull Request

Description

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

240930_14h28m43s_screenshot

Additional context

pokeget vs other similar project
240930_14h21m23s_screenshot

pokeget vs pokemon-colorscripts
240930_14h21m48s_screenshot

@rubiin
Copy link
Contributor

rubiin commented Sep 30, 2024

LGTM here is a comparision
Pokeget
image

Pokemon scripts
image

Pokeget sure looks faster nearly 10x

@rubiin
Copy link
Contributor

rubiin commented Oct 1, 2024

So I published my rewrite on aur and its backward compatible with the pokemon scripts. Also the rust build takes a lot time comparatively . It matches the speed of the rust and will be receiving updates and features ,
Perhaps we can switch to this?
image

https://github.com/rubiin/pokego

Will be adding a bin version too

@rishav12s
Copy link
Contributor Author

@rubiin looks good but is compilation time that much of a factor ?

sure go is compiled faster but i dont think it will make that much of difference as the rust one should be like 30 secs or a minute more

another thing i noticed (again a very minor difference) that the package size is bigger for pokego (40+ mb) while pokeget is 4mb

i read that the sprites need to stored locally or something for pokemon-colorscripts ig thats why the difference

@rubiin
Copy link
Contributor

rubiin commented Oct 1, 2024

@rishav12s thats fixed. Its now 5 mb

@rishav12s
Copy link
Contributor Author

@rubiin nice its a 50-50 decision ig now

lets see what khing has to say on this one

then i will get the changes done accordingly

@rubiin
Copy link
Contributor

rubiin commented Oct 1, 2024

image

I trimmed down to 5mb lol :D
Basically sprites are packaged within the app so that was causing the size spike.

@abenezerw
Copy link
Contributor

Honestly if this launches kitty faster 🤙. Cause there’s already a delay where if you start typing right after you hit super Q. Half your text is above the line

@rishav12s
Copy link
Contributor Author

@abenezerw sadly this wont be merged anytime soon as khing said that the installation packages should be according to tittu's preferences as it is his dotfiles

for now ig you can get the packages and manually replace the command in .zshrc

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Oct 6, 2024

I'll confirm that.

How about we make a repo similar to this or a wiki
https://github.com/hyprland-community/awesome-hyprland

Having good defaults is good but again this is not my repo and we already have a working defaults. I would suggest we can wrap around HyDE with things that can extend its functionality.

@rubiin
Copy link
Contributor

rubiin commented Oct 8, 2024

@kRHYME7 added a sample page . we can add more stuffs https://hydeproject.pages.dev/reference/tools/

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Oct 19, 2024

So I want to join. 😄

I guess time command works different on each device so this is pokego vs puke

image

Just wanted to join the fun. As I'm learning Go, I tried porting it to cpp.

but fk cpp no std for embed!

Edit: Added hyperfines benchmark
image

And in release build
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants