-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds swayosd #1818
base: main
Are you sure you want to change the base?
feat: adds swayosd #1818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace the title with "feat: adds swayosd"
@kRHYME7 LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add show_percentage = true
, latest build suports it
I don't know if I can merge this. I won't even touch his keybindings, which uses the scripts . I will suggest making this an optional package (Not all is using chaotic-aur) I can merge these only If I don't mess up his config. We can add a Markdown for extending HyDE capability, in which I am trying to do with Hyprpanel.
Sorry, this might be an inconvenience, but the owner is always trying to lessen the repo's dependencies. |
I checked hyprpanel. Looks good. It also has an osd , are we gonna switch from waybar to that? or will there be an option to choose |
No options on intallation yet but an extensive wiki for extension yes. (Hope so). |
How about leaving the pulseaudio and backlight as is and make a separate module for swayosd? |
i understand what you say and why...i will work on it in this weekend and if you have any idea to how separate this two configs well pls share with us because we have conflict with keybindings too |
Sure Sure. Will Edit the PR |
Scripts/system_ctl.lst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this if we start swayosd-server and invoke using swayosd-client
btw @TheyCallMeSecond can you also compare the memory usage of hyprpanel and waybar. I am skeptical on the memory part of hyprpanel as its on typescript afaik Also hyprpanel has inbuilt osd https://hyprpanel.com/configuration/osd.html so swayosd would not be needed i guess |
I was afraid of that, thats like twice the memory. Because typescript is not so great on memory . I think I will stick to waybar for now |
This repo will always use waybar by default unless tittu will change it. What I can do is to make integration with external dotfiles to hyde. I'm looking forward to swayosd as this one requires minimal change. ie the volume and backlight script PR. that one doesn't require extra configuration for the users. |
yeah. hyprpanel is a big change. |
@kRHYME7 using ags . The creators dotfiles |
Hyprpanel is built over ags, |
yeah . But depends if how much you can customize |
im using ags like this right now |
Got more bugs from hyprpanel, but overall we can support wallbash and theming. So |
Pull Request
Description
Type of change
Please put an
x
in the boxes that apply:Checklist
Please put an
x
in the boxes that apply: