Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use apps exported from shell #1814

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rubiin
Copy link
Contributor

@rubiin rubiin commented Sep 7, 2024

Pull Request

This helps user to user apps from their shell without having to tweak the keybindings file. Also it removes the hardcoded app values on keybinds making it open to more optimizations

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

@rubiin
Copy link
Contributor Author

rubiin commented Sep 12, 2024

@kRHYME7 this can be merged

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 12, 2024

can't, how are we sure that users starts from zsh or fish. These are called environment variables. There should a better way to do it. example using xdg commands

@rubiin
Copy link
Contributor Author

rubiin commented Sep 15, 2024

As of now, I am using this without any issues so far. My default shell is zsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants