Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve Flatpak installation script for better user interaction … #1793

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShinniUwU
Copy link

Pull Request

Description

This pull request introduces improvements to the Flatpak installation script by adding user interaction features, such as a selection menu and confirmation prompts. These enhancements aim to provide a more user-friendly experience during the installation of Flatpak applications.

Summary of Changes

  • Added an interactive menu to allow users to select specific Flatpak applications or install all at once.
  • Implemented a confirmation prompt to review choices before proceeding with the installation.
  • Added error handling for cases where the application list is empty or invalid.
  • Included setup commands to ensure Flatpak applications have access to GTK themes and icons.

Motivation and Context

The previous script lacked user interaction and always installed all applications listed in the configuration file. The new script allows for more control over the installation process, making it more flexible and user-friendly.

Dependencies

  • No new dependencies are introduced. The script relies on existing functions from global_fn.sh, specifically pkg_installed.

Related Issues

N/A

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentation)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

N/A

Additional context

Copy link
Collaborator

@kRHYME7 kRHYME7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for others to approve this. I scanned through the script and it looks good to me.

Copy link
Contributor

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 1, 2024

@rubiin Have you tried running the script?

@rubiin
Copy link
Contributor

rubiin commented Sep 1, 2024

Nah I just verified the code visually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants