Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scripts - ddcutil script to handle brightness control for extern… #1771

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Melk0rr
Copy link

@Melk0rr Melk0rr commented Aug 22, 2024

A new script based on the default brightnesscontrol.sh but using ddcutil to control the brightness of external monitors.

The main issue is : DDC/CI protocol is slow

Pull Request

Description

  • This script tries to achieve what the original brightnesscontrol script does with brightnessctl but for external monitors
  • As I use 3 external monitors, I lacked a utility to easily change brightness. So here it is
  • Dependencies: ddcutil only
  • Related issue

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

screenshot_20240822_17h55m26s

Additional context

…al monitors

A new script based on the default brightnesscontrol.sh but using ddcutil to control the brightness of external monitors.

The main issue is : DDC/CI protocol is slow
@Melk0rr Melk0rr changed the title new: scripts - ddcutil script to handle brightness control for extern… feat: scripts - ddcutil script to handle brightness control for extern… Aug 22, 2024
Tweaked comments and print_error
@guoyatingg
Copy link

Good afternoon, I'm not a programmer at all, but I changed something in your script and it seems to work faster
brightnesscontrol.zip

@Melk0rr
Copy link
Author

Melk0rr commented Aug 25, 2024

Yep, you're right, updated to implement a variable

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Aug 26, 2024

Sadly I can't test this one yet as my external monitor don't have ddc/ci, will try to find someone having that proto.

@abenezerw
Copy link
Contributor

image
This works, would be nice to control external monitor brightness from ui.

@abenezerw
Copy link
Contributor

but for some reason cant control it with scroll wheel over waybar though. just from terminal. is that also possible? @Melk0rr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants