Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sddm bg change script for the new theme layout #1499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drnikos
Copy link

@drnikos drnikos commented May 14, 2024

Pull Request

Description

Modified the old sddmwall.sh script to work in the new theme format, and now it reads the current desktop and sddm theme (only tested it on corners theme) and changes the background of the sddm theme to the current wallpaper

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

@abenezerw
Copy link
Contributor

Its not working on my system if its just putting that file into the directory.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented May 14, 2024

Would t be fair if I add a functionality same as this in the Hyde-cli ?

@drnikos
Copy link
Author

drnikos commented May 14, 2024

Its not working on my system if its just putting that file into the directory.

Are you using the Candy theme? I think it selects randomly one of the backgrounds in the background directory,
240514_15h21m57s_screenshot

the script replaces the bg.png, so I kept only that in the BackgroundS, and now it always uses that bg.
240514_15h21m08s_screenshot

@drnikos
Copy link
Author

drnikos commented May 14, 2024

Would t be fair if I add a functionality same as this in the Hyde-cli ?

It woud be nice!

@abenezerw
Copy link
Contributor

abenezerw commented Sep 23, 2024

This is achievable without a script by just giving traversal access to sddm by:
setfacl -m u:sddm:x /home/$USER/.cache

then read access also
setfacl -m u:sddm:r /home/$USER/.cache/hyde/wall.set

And setting this as the path to wallpaper in sddm.
/home/$USER/.cache/hyde/wall.set

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Sep 23, 2024

That one is not a perfect solution, as the multi-user might be confused and will have permission issues. Not all knows how to manage system configs.

Can you check if using /var/tmp is a viable solution?

This way we can just use /var/tmp/hyde/wall.set like cp current wall to this directory

only preparation we need is

mkdir -p   /var/tmp/hyde
 chmod go+xw  /var/tmp/hyde

@keth-real
Copy link
Contributor

@abenezerw @kRHYME7 @drnikos

I managed to do it! Exposing the wallpaper to /var/tmp should be fine.

#1906

We just need to manually enable It for each theme by changing Background= into Background="/var/tmp/hyde/wall.set"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants