Automatically Closing the Location List For Diagnostics

[husainaloos]

Currently when Diagnostics command is run, a location list will be open. When these diagnostics are fixed in the code, running the command does not automatically close the location list. I suggest that the list should be automatically closed.

The code in question:

vim-lsp/autoload/lsp/ui/vim/diagnostics.vim

Lines 64 to 68 in a943fe5

	if empty(l:result)
	call lsp#utils#error('No diagnostics results found')
	else
	echo 'Retrieved diagnostics results'
	botright lopen

The suggested change is to use botright lwindow in both the if and the else (replacing botright lopen).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tshirtman]

Code has moved to

vim-lsp/autoload/lsp/internal/diagnostics/document_diagnostics_command.vim

Lines 32 to 37 in f7ccf00

	if empty(l:result)
	call lsp#utils#error('No diagnostics results')
	return
	else
	call setloclist(0, l:result)
	echo 'Retrieved diagnostics results'

but still the same behavior. I changed that code locally to

    if empty(l:result)
        call lsp#utils#error('No diagnostics results')
    else
        echo 'Retrieved diagnostics results'
    endif
    call setloclist(0, l:result)
    botright lwindow

(lwindow didn’t close if the loclist wasn’t emptied)
and it works as i want it. I can make a MR for it.