Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some game default key bindings conflict with crucial system shortcuts on macOS #30856

Open
frenzibyte opened this issue Nov 24, 2024 · 3 comments

Comments

@frenzibyte
Copy link
Member

Namely:

  • new KeyBinding(new[] { InputKey.Control, InputKey.Up }, GlobalAction.IncreaseModSpeed),
    new KeyBinding(new[] { InputKey.Control, InputKey.Down }, GlobalAction.DecreaseModSpeed),

    This conflicts with the shortcut Ctrl-Up used to trigger "Mission Control" and the shortcut Ctrl-Down used to display all windows of the focused application.

  • new KeyBinding(new[] { InputKey.Control, InputKey.Left }, GlobalAction.EditorSeekToPreviousHitObject),
    new KeyBinding(new[] { InputKey.Control, InputKey.Right }, GlobalAction.EditorSeekToNextHitObject),
    new KeyBinding(new[] { InputKey.Control, InputKey.Shift, InputKey.Left }, GlobalAction.EditorSeekToPreviousSamplePoint),
    new KeyBinding(new[] { InputKey.Control, InputKey.Shift, InputKey.Right }, GlobalAction.EditorSeekToNextSamplePoint),

    This conflicts with the shortcut Ctrl-Left and Ctrl-Right used to navigate between desktop spaces. The last two don't necessarily conflict but they technically derive from the ones above them.

cc @peppy

@peppy
Copy link
Member

peppy commented Nov 26, 2024

Probably should use command instead of control for macOS only.

@frenzibyte
Copy link
Member Author

Sounds good. Would you also agree to change all key bindings to use Command or only the ones listed above? Based on my many-but-not-so-many years of experience with macOS, I think it's more natural for us to use Command as much as possible and fall back to Control if we cannot use Command for a particular key binding.

Referencing Apple's human interface guidelines (which we don't have to necessarily follow but it provides best practices for macOS etc.):

CleanShot 2024-11-26 at 13 25 30

Here's the list of all key bindings using Control for reference:

Additionally, we can also change o!f bindings to use Command and therefore not have to manually go to our settings and unbind some system shortcuts because it conflicts with Ctrl-F1 for draw visualiser etc.

@peppy
Copy link
Member

peppy commented Nov 27, 2024

It's a large change but yes, I'd support moving them all over.

@frenzibyte frenzibyte self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants