Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "Edit Externally" resets the beatmap's Date Added #29233

Closed
kstefanowicz opened this issue Aug 1, 2024 · 2 comments · Fixed by #29256
Closed

Using "Edit Externally" resets the beatmap's Date Added #29233

kstefanowicz opened this issue Aug 1, 2024 · 2 comments · Fixed by #29256
Assignees
Labels
area:import dealing with importing of data from stable or file formats

Comments

@kstefanowicz
Copy link
Contributor

Type

Game behaviour

Bug description

After using "Edit Externally" and opening the .osu file, the beatmap's Date Added is reset to today

Screenshots or videos

issue-edit-external-date-added.webm

Version

2024.731.0-lazer

Logs

compressed-logs.zip

@SupDos
Copy link
Contributor

SupDos commented Aug 1, 2024

Some more specifics regarding this: it seems to reset the date added only if you don't change anything when editing externally. If you edit a file, add a new one or delete anything then it keeps the correct date added.

@peppy
Copy link
Member

peppy commented Aug 2, 2024

Thanks for the added information. This means it's the "undelete" workflow working "as intended". Not sure if we should just nuke that code and make undeletes use the original date added, seems the easiest.

existing.DateAdded = DateTimeOffset.UtcNow;

@peppy peppy self-assigned this Aug 2, 2024
@peppy peppy added the area:import dealing with importing of data from stable or file formats label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:import dealing with importing of data from stable or file formats
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants