Vertex should not automatically added when editing juicestream that being selected in catch editor

[Sololiquy]

Type

Game behaviour

Bug description

Add or delete vertex will cause some vertex automatically added while juicestream being selected, this can be pretty annoying when edit juicestream with high SV

In previous version, vertex only added when juicestream unselected.

Screenshots or videos

2024-07-25.12-11-24.mp4

Version

2024.725.0-lazer

Logs

[bdach]

I'm not really even sure why these exist, I'll have to educate myself. I'd like to think that maybe we can just not have them at all rather than them show up by magic at one point or another.

[peppy]

The extra point being added here looks like a pretty clear bug.

[bdach]

I mean you can say that and I agree but reading the code it looks like it was being added for a reason I don't currently understand. Maybe @ekrctb could shed some light on this if still around to read notifications.

[snalgae]

I actually know an answer for this one, those are the places where a slider is bumping an edge of a screen, it is very visible in the stable editor

[bdach]

If that is the case I'd honestly consider not adding these points for stable's sake. Or at least only doing it for compatibility export.

[peppy]

Probably fine to just not add them..

[snalgae]

Would also removing things like slider velocities or y-axis inside the lazer editor be better?

Having a structure independent of the osu!standard game mode will allow for things to be easier to build upon. There wouldn't be a need to manage osu!standard's mechanics inside the osu!catch editor. It is also more intuitive to not have these characteristics on objects. The y-axis is not modifiable and it doesn't affect gameplay (as far as I know). SV affects sliders built in osu!standard mode which in osu!catch correlate to their x-axis projections. I would assume modifying the SV value squishes or stretches the slider shape vertically. (if the shape itself is not modified)

But many osu!catch mappers have used slider velocities and y-axis to communicate spacing and patterns, so will this option be uninviting to them? It would also affect compatibility, but I'm not knowledgeable enough to know how it would affect it (I would assume it will since it removes core features of osu!standard gameplay)

[bdach]

"Slider velocity" is already a conversion artifact at best in catch contexts so we could hide it from the catch editor maybe. I'd have to consult with catch mappers though, to ensure they don't have SV ranges in RC or rely on it in some other manner.

I'm not sure what you mean by "removing the y-axis" means though in terms of lazer editor?

[snalgae]

I'm not sure what you mean by "removing the y-axis" means though in terms of lazer editor?

I mean it is not really shown beyond the inspector. I thought more of removing it internally, but I'm thinking if that is even necessary? Would it impede things like creation of curves, if such feature would be added?

[bdach]

Curves are going to be deathly complicated to make work as long as we are chained to the old beatmap file format. It's going to be a whole math assignment to make curves made in catch editor back-translate to sliders. So I dunno about that, and it's a discussion out of scope of this thread.

[snalgae]

I guess my point of bringing my original point up, is because I thought removing SV and y-axis values from objects would solve this issue, since then there would need to be some other way to calculate objects, but I see now that just making the extra vertices not editable is a more obvious solution. I totally overcomplicated this in my head