From ccaac977947174af7d8de690f90f5977b230242d Mon Sep 17 00:00:00 2001 From: StanR Date: Sat, 16 Oct 2021 14:50:15 +0300 Subject: [PATCH] Clamp comboBasedMissCount --- osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs b/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs index 3895389f61ab..4bca87204ad1 100644 --- a/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs +++ b/osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs @@ -265,6 +265,9 @@ private int calculateEffectiveMissCount() comboBasedMissCount = fullComboThreshold / Math.Max(1.0, scoreMaxCombo); } + // we're clamping misscount because since its derived from combo it can be higher than total hits and that breaks some calculations + comboBasedMissCount = Math.Min(comboBasedMissCount, totalHits); + return Math.Max(countMiss, (int)Math.Floor(comboBasedMissCount)); }